Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint/sort-keys #4845

Merged
merged 37 commits into from
Sep 11, 2024
Merged

feat(linter): eslint/sort-keys #4845

merged 37 commits into from
Sep 11, 2024

Conversation

Goldziher
Copy link
Contributor

This PR adds the eslint/sort-keys implementation as part of #479

Note: two tests are commented out. I was not able to model this behavior properly. I would be happy to have some assistance there.

@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Aug 12, 2024
@Goldziher Goldziher changed the title Feat: eslint/sort-keys feat(linter): eslint/sort-keys Aug 12, 2024
DonIsaac
DonIsaac reviewed Aug 12, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/eslint/sort_keys.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/eslint/sort_keys.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/eslint/sort_keys.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/eslint/sort_keys.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/eslint/sort_keys.rs Outdated Show resolved Hide resolved
@DonIsaac
Copy link
Contributor

Thanks for your contribution to oxc! This looks pretty good, just a few things to polish off.

@DonIsaac DonIsaac added C-enhancement Category - New feature or request first-pr labels Aug 12, 2024
@Goldziher Goldziher requested a review from DonIsaac August 12, 2024 15:02
@Goldziher
Copy link
Contributor Author

Thanks for your contribution to oxc! This looks pretty good, just a few things to polish off.

Great. I addressed all comments.

DonIsaac
DonIsaac reviewed Aug 12, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@Goldziher Goldziher requested review from DonIsaac and rzvxa August 13, 2024 05:30
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4845 will not alter performance

Comparing Goldziher:main (45418d6) with main (21e2df5)

Summary

✅ 29 untouched benchmarks

@DonIsaac
Copy link
Contributor

@rzvxa feel free to merge this when CI is passing and you are ready.

@Goldziher
Copy link
Contributor Author

@rzvxa is this PR done?

@DonIsaac
Copy link
Contributor

@rzvxa appears busy, I'll review this in the morning.

@DonIsaac DonIsaac self-assigned this Aug 31, 2024
@Boshen Boshen removed the first-pr label Sep 5, 2024
@Goldziher
Copy link
Contributor Author

@rzvxa appears busy, I'll review this in the morning.

Anything?

@DonIsaac
Copy link
Contributor

DonIsaac commented Sep 6, 2024

Apologies for the delay, I got sidetracked 😅

@Goldziher
Copy link
Contributor Author

@DonIsaac I addressed your comments and made the changes. I cannot resolve the merge conflict - please push a fix to this branch.

@DonIsaac
Copy link
Contributor

DonIsaac commented Sep 6, 2024

@DonIsaac I addressed your comments and made the changes. I cannot resolve the merge conflict - please push a fix to this branch.

The conflicts aren't too bad, I believe in you 😄

@Goldziher
Copy link
Contributor Author

@DonIsaac I addressed your comments and made the changes. I cannot resolve the merge conflict - please push a fix to this branch.

The conflicts aren't too bad, I believe in you 😄

That's not the issue. Ill need to add a second remote now, but I'll do it.

@Goldziher
Copy link
Contributor Author

Should be good to go @DonIsaac

@DonIsaac
Copy link
Contributor

DonIsaac commented Sep 7, 2024

Once CI is passing we can merge this

@Goldziher
Copy link
Contributor Author

@DonIsaac I rebased on main and handled just r. Please merge this PR - it has been lingering long enough.

@DonIsaac DonIsaac merged commit 9ca2593 into oxc-project:main Sep 11, 2024
27 checks passed
@oxc-bot oxc-bot mentioned this pull request Sep 12, 2024
Merged
Boshen added a commit that referenced this pull request Sep 12, 2024
@oxc-bot @Boshen @autofix-ci
release(oxlint): v0.9.4 (#5718)
d06bab6 
## [0.9.4] - 2024-09-12

### Features

- 9ca2593 linter: Eslint/sort-keys  (#4845) (Na'aman Hirschfeld)
- 023c160 linter: Impl `Serialize` for `OxlintConfig` (#5594) (DonIsaac)
- 24d6a47 linter: Implement `eslint/no-invalid-regexp` (#5443) (Boshen)

### Bug Fixes

- af6d240 linter: Panic in consistent-function-scoping (#5613)
(DonIsaac)
- 54e2e76 linter: `react/no_set_state` + `react/no_string_refs` rules
find correct parent (#5615) (overlookmotel)
- 3b87ac4 linter: Fix no_unused_vars panic when encountering unicode
(#5582) (Boshen)

### Performance

- bfe9186 linter: Use `cow_replace` instead of `replace` (#5643)
(dalaoshu)
- e3ae5db linter: Use cow_to_ascii_lowercase/uppercase (#5637) (heygsc)
- a0370bf linter: Use cow_utils in no_script_url (#5633) (heygsc)
- 37e922c linter: `eslint/no_shadow_restricted_names` use
`run_on_symbol` (#5618) (overlookmotel)
- 0b7fccf linter: `react/no_set_state` + `react/no_string_refs` rules
reduce iteration over ancestors (#5616) (overlookmotel)
- 2c3f3fe linter: Make `jsx_key` slightly faster (#5585) (Boshen)
- cd81d12 linter: Add `should_run` to check path only once to
nextjs/no_typos (#5584) (Boshen)
- d18c896 rust: Use `cow_utils` instead (#5664) (dalaoshu)

### Documentation

- 64f9575 linter: Add plugin usage to example with configuration
(Boshen)
- 8c9179d linter: Fix typos (#5591) (Brian Donovan)

### Refactor

- 9e9435f linter: Add `LintFilter` (#5685) (DonIsaac)
- 4f70fe5 linter: Start internal/external split of LintPluginOptions
(#5660) (DonIsaac)
- 5ae9b48 linter: Start internal/external split of `OxlintOptions`
(#5659) (DonIsaac)
- c8bc6f0 linter: Use `std::ptr::eq` (#5649) (overlookmotel)
- a37c064 linter: Use `ContentHash` for `no_duplicate_case`; remove
`calculate_hash` (#5648) (Boshen)
- 0b3c1d7 linter: Start internal/external split of `OxlintConfig`
(#5595) (DonIsaac)
- 89bdf55 linter: Inline `Rule` trait default methods (#5619)
(overlookmotel)
- afea8d5 linter: Rename `Rule` trait method params (#5617)
(overlookmotel)
- 4e748b5 linter: Replace ast "compare by hash" to "compare by content"
(#5602) (dalaoshu)
- bac03e3 linter: Make fields of `LintServiceOptions` private (#5593)
(DonIsaac)
- 2661d8b linter: Jest prefer_strict_equal (#5588) (IWANABETHATGUY)
- 20d0068 oxlint: Move cli-related exports to `cli` module (#5139)
(DonIsaac)
- 067f9b5 semantic: Introduce `IsGlobalReference` trait (#5672)
(Boshen)- 26d9235 Enable clippy::ref_as_ptr (#5577) (夕舞八弦)

### Testing

- 8e79f8d linter: Add class method test cases for `oxc/no-async-await`
(#5550) (DonIsaac)
- 3835189 linter: Add test case for no_unused_vars in 3b87ac4 (Boshen)
- 5f27551 linter: Add a passing case to no_undef (#5580) (Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This was referenced Sep 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonIsaac DonIsaac DonIsaac approved these changes

@jelly jelly jelly left review comments

@rzvxa rzvxa Awaiting requested review from rzvxa

Assignees

@DonIsaac DonIsaac

Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Goldziher @DonIsaac @rzvxa @jelly @Boshen