Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(minifier): fix minimize condition tests #7222

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 9, 2024

No description provided.

Copy link

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@7086cmd 7086cmd marked this pull request as ready for review November 9, 2024 11:01
@7086cmd 7086cmd requested a review from Boshen November 9, 2024 11:01
Copy link
Contributor Author

7086cmd commented Nov 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @7086cmd and the rest of your teammates on Graphite Graphite

@7086cmd 7086cmd added the A-minifier Area - Minifier label Nov 9, 2024 — with Graphite App
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 9, 2024
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #7222 will not alter performance

Comparing 11-09-test_minifier_fix_minimize_condition_tests (0d6a66a) with main (080a67b)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen changed the base branch from 11-06-refactor_minifier_prefer_map_and_and_then_ to graphite-base/7222 November 9, 2024 11:48
@Boshen Boshen force-pushed the graphite-base/7222 branch from ec477df to a297765 Compare November 9, 2024 11:53
@Boshen Boshen force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch from 3db70fd to 4ba479a Compare November 9, 2024 11:53
@Boshen Boshen changed the base branch from graphite-base/7222 to main November 9, 2024 11:54
@Boshen Boshen force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch from 4ba479a to c0e4c59 Compare November 9, 2024 11:54
@7086cmd 7086cmd force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch 3 times, most recently from e2101f9 to e501872 Compare November 10, 2024 00:47
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2024
Copy link
Member

Boshen commented Nov 11, 2024

Merge activity

  • Nov 11, 3:36 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 3:36 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 3:40 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch from e501872 to 0d6a66a Compare November 11, 2024 08:36
@graphite-app graphite-app bot merged commit 0d6a66a into main Nov 11, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-09-test_minifier_fix_minimize_condition_tests branch November 11, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants