Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifier): prevent removing if when side effected #7223

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 9, 2024

related: #7209

But it can be optimized but not in this case.

Copy link

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Nov 9, 2024
Copy link
Contributor Author

7086cmd commented Nov 9, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @7086cmd and the rest of your teammates on Graphite Graphite

@7086cmd 7086cmd marked this pull request as ready for review November 9, 2024 11:09
@7086cmd 7086cmd requested a review from Boshen November 9, 2024 11:09
@7086cmd 7086cmd force-pushed the 11-09-fix_minifier_prevent_removing_if_when_side_effected branch 2 times, most recently from db10bd9 to 52026c4 Compare November 9, 2024 11:15
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #7223 will not alter performance

Comparing 11-09-fix_minifier_prevent_removing_if_when_side_effected (6ab27ca) with 11-09-test_minifier_fix_minimize_condition_tests (e501872)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch 2 times, most recently from 4ba479a to c0e4c59 Compare November 9, 2024 11:54
@Boshen Boshen force-pushed the 11-09-fix_minifier_prevent_removing_if_when_side_effected branch from 52026c4 to 85e106b Compare November 9, 2024 11:54
@7086cmd 7086cmd force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch from c0e4c59 to 1bbfa1b Compare November 10, 2024 00:06
@7086cmd 7086cmd force-pushed the 11-09-fix_minifier_prevent_removing_if_when_side_effected branch from 85e106b to 82c2fec Compare November 10, 2024 00:07
@7086cmd 7086cmd force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch from 0dd1d43 to e2101f9 Compare November 10, 2024 00:09
@7086cmd 7086cmd force-pushed the 11-09-fix_minifier_prevent_removing_if_when_side_effected branch from 6e68b3c to 7771afc Compare November 10, 2024 00:09
@7086cmd 7086cmd force-pushed the 11-09-test_minifier_fix_minimize_condition_tests branch from e2101f9 to e501872 Compare November 10, 2024 00:47
@7086cmd 7086cmd force-pushed the 11-09-fix_minifier_prevent_removing_if_when_side_effected branch from 7771afc to 6ab27ca Compare November 10, 2024 00:48
@Boshen Boshen closed this Nov 11, 2024
@Boshen Boshen deleted the 11-09-fix_minifier_prevent_removing_if_when_side_effected branch November 11, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants