Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(transformer/nullish-coalescing): clarify doc comment #7268

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 13, 2024

Expand doc comment for create_conditional_expression to clarify what it does.

Copy link

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-docs Category - Documentation. Related to user-facing or internal documentation labels Nov 13, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 13, 2024 12:07
@overlookmotel
Copy link
Contributor Author

overlookmotel commented Nov 13, 2024

@Dunqing I was having trouble understanding this transform while doing #7266. This is a small docs nit, but could you please check I have it correct?

Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #7268 will not alter performance

Comparing 11-13-docs_transformer_nullish-coalescing_correct_doc_comment (e219ae8) with main (01ddf37)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as draft November 13, 2024 12:31
@overlookmotel overlookmotel force-pushed the 11-13-docs_transformer_nullish-coalescing_correct_doc_comment branch from 3689849 to 0ccb2ed Compare November 13, 2024 12:37
@overlookmotel overlookmotel marked this pull request as ready for review November 13, 2024 12:38
@overlookmotel overlookmotel changed the title docs(transformer/nullish-coalescing): correct doc comment docs(transformer/nullish-coalescing): clarify doc comment Nov 13, 2024
@overlookmotel overlookmotel force-pushed the 11-13-docs_transformer_nullish-coalescing_correct_doc_comment branch from 0ccb2ed to bea58ba Compare November 13, 2024 15:35
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 14, 2024
Copy link

graphite-app bot commented Nov 14, 2024

Merge activity

Expand doc comment for `create_conditional_expression` to clarify what it does.
@Boshen Boshen force-pushed the 11-13-docs_transformer_nullish-coalescing_correct_doc_comment branch from bea58ba to e219ae8 Compare November 14, 2024 16:17
@graphite-app graphite-app bot merged commit e219ae8 into main Nov 14, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-13-docs_transformer_nullish-coalescing_correct_doc_comment branch November 14, 2024 16:22
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
Expand doc comment for `create_conditional_expression` to clarify what it does.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Expand doc comment for `create_conditional_expression` to clarify what it does.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Expand doc comment for `create_conditional_expression` to clarify what it does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant