refactor(transformer/nullish-coalescing): avoid repeated symbol lookups #7272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
This was referenced Nov 13, 2024
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7272 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
11-13-refactor_transformer_nullish-coalescing_avoid_repeated_symbol_lookups
branch
from
d23e8da to
4ced135
Compare
Merge activity
|
…ps (#7272) `clone_expression` was unnecessarily looking up the `SymbolId` of references multiple times. Use `BoundIdentifier` instead to avoid that. Notes: * `create_conditional_expression` has to take all parts as `Expression`s just to support `this ?? something`. * `TraverseCtx::is_static` also handles `Super`, but can skip that in this case as `super ?? something` is not valid syntax.
Boshen
force-pushed
the
11-13-fix_transformer_nullish-coalescing_correct_span
branch
from
7428d93 to
5b5c8a9
Compare
Boshen
force-pushed
the
11-13-refactor_transformer_nullish-coalescing_avoid_repeated_symbol_lookups
branch
from
4ced135 to
345fbb9
Compare
Base automatically changed from
11-13-fix_transformer_nullish-coalescing_correct_span
to
main
November 14, 2024 16:28
graphite-app
bot
deleted the
11-13-refactor_transformer_nullish-coalescing_avoid_repeated_symbol_lookups
branch
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
…ps (#7272) `clone_expression` was unnecessarily looking up the `SymbolId` of references multiple times. Use `BoundIdentifier` instead to avoid that. Notes: * `create_conditional_expression` has to take all parts as `Expression`s just to support `this ?? something`. * `TraverseCtx::is_static` also handles `Super`, but can skip that in this case as `super ?? something` is not valid syntax.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
…ps (#7272) `clone_expression` was unnecessarily looking up the `SymbolId` of references multiple times. Use `BoundIdentifier` instead to avoid that. Notes: * `create_conditional_expression` has to take all parts as `Expression`s just to support `this ?? something`. * `TraverseCtx::is_static` also handles `Super`, but can skip that in this case as `super ?? something` is not valid syntax.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
…ps (#7272) `clone_expression` was unnecessarily looking up the `SymbolId` of references multiple times. Use `BoundIdentifier` instead to avoid that. Notes: * `create_conditional_expression` has to take all parts as `Expression`s just to support `this ?? something`. * `TraverseCtx::is_static` also handles `Super`, but can skip that in this case as `super ?? something` is not valid syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clone_expressionwas unnecessarily looking up theSymbolIdof references multiple times. UseBoundIdentifierinstead to avoid that.Notes:
create_conditional_expressionhas to take all parts asExpressions just to supportthis ?? something.TraverseCtx::is_staticalso handlesSuper, but can skip that in this case assuper ?? somethingis not valid syntax.