fix(codegen): fix arithmetic overflow printing unspanned NewExpression
#7289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@Boshen I'm not sure if this is the best way to solve the problem? |
CodSpeed Performance ReportMerging #7289 will not alter performanceComparing Summary
|
Merge activity
|
…on` (#7289) `self.span.end - 1` overflows if the `NewExpression` is generated in transformer and has no span, so `self.span.end == 0`.
Boshen
force-pushed
the
11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_newexpression_
branch
from
6de410a to
33ec4e6
Compare
graphite-app
bot
deleted the
11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_newexpression_
branch
Boshen
pushed a commit
that referenced
this pull request
Nov 15, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Boshen
pushed a commit
that referenced
this pull request
Nov 15, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
…on` (#7289) `self.span.end - 1` overflows if the `NewExpression` is generated in transformer and has no span, so `self.span.end == 0`.
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
…on` (#7289) `self.span.end - 1` overflows if the `NewExpression` is generated in transformer and has no span, so `self.span.end == 0`.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
…on` (#7289) `self.span.end - 1` overflows if the `NewExpression` is generated in transformer and has no span, so `self.span.end == 0`.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.span.end - 1overflows if theNewExpressionis generated in transformer and has no span, soself.span.end == 0.