Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer): script to amend Babel fixtures #7122

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 4, 2024

Add a NodeJS script which amends Babel's fixtures in place to remove transform plugins which we don't support from options.json files. Where options are changed from the original, the script runs Babel transform with the new options to regenerate the fixture output.js files.

Currently limited to transforming the fixtures for babel-plugin-transform-class-properties transform, but we can also enable it for other plugins if we wish in future, to get additional test coverage.

Copy link

graphite-app bot commented Nov 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 4, 2024
Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #7122 will not alter performance

Comparing 11-04-test_transformer_script_to_amend_babel_fixtures (7f0dd2c) with 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s (1a6116b)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen changed the base branch from 11-04-refactor_ast_use_scope_id_etc_methods to graphite-base/7122 November 5, 2024 02:27
@Boshen Boshen force-pushed the graphite-base/7122 branch from 80ea830 to fac5042 Compare November 5, 2024 02:54
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from f559460 to 5dde378 Compare November 5, 2024 02:54
@Boshen Boshen changed the base branch from graphite-base/7122 to main November 5, 2024 02:55
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 5dde378 to 3dfe91b Compare November 5, 2024 02:55
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 3 times, most recently from 5dbd95a to 8f6d9bd Compare November 6, 2024 22:26
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 3 times, most recently from fdf277f to 7b2ad89 Compare November 15, 2024 00:38
@overlookmotel overlookmotel changed the base branch from main to 11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_newexpression_ November 15, 2024 00:38
@Boshen Boshen changed the base branch from 11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_newexpression_ to graphite-base/7122 November 15, 2024 02:56
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 7b2ad89 to e306f43 Compare November 15, 2024 03:01
@Boshen Boshen force-pushed the graphite-base/7122 branch from 6de410a to 33ec4e6 Compare November 15, 2024 03:01
@Boshen Boshen changed the base branch from graphite-base/7122 to main November 15, 2024 03:02
@Boshen Boshen force-pushed the graphite-base/7122 branch from be24ab0 to f4fda2d Compare November 22, 2024 02:27
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 1085f5b to ed78070 Compare November 22, 2024 02:27
@Boshen Boshen changed the base branch from graphite-base/7122 to main November 22, 2024 02:28
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from ed78070 to 7c6f29b Compare November 22, 2024 02:28
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 2 times, most recently from 2f069d1 to 7f0dd2c Compare November 22, 2024 10:51
@overlookmotel overlookmotel changed the base branch from main to 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s November 22, 2024 10:52
@overlookmotel overlookmotel force-pushed the 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s branch 2 times, most recently from 5e497b3 to bc85b2b Compare November 22, 2024 11:05
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 7f0dd2c to eeeccba Compare November 22, 2024 11:05
@Boshen Boshen changed the base branch from 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s to graphite-base/7122 November 22, 2024 12:31
@Boshen Boshen force-pushed the graphite-base/7122 branch from bc85b2b to 971c91a Compare November 22, 2024 12:36
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from eeeccba to 3d4a890 Compare November 22, 2024 12:36
@Boshen Boshen changed the base branch from graphite-base/7122 to main November 22, 2024 12:37
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 3d4a890 to 8d1ea70 Compare November 22, 2024 12:37
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 2 times, most recently from b4c5bea to 8248e29 Compare November 24, 2024 12:09
@overlookmotel overlookmotel marked this pull request as ready for review November 24, 2024 14:12
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 8248e29 to 2c34991 Compare November 24, 2024 17:42
@overlookmotel overlookmotel requested a review from Boshen November 24, 2024 17:47
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 2c34991 to 25f2a20 Compare November 24, 2024 17:59
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 25, 2024
Copy link

graphite-app bot commented Nov 25, 2024

Merge activity

Add a NodeJS script which amends Babel's fixtures in place to remove transform plugins which we don't support from `options.json` files. Where options are changed from the original, the script runs Babel transform with the new options to regenerate the fixture `output.js` files.

Currently limited to transforming the fixtures for `babel-plugin-transform-class-properties` transform, but we can also enable it for other plugins if we wish in future, to get additional test coverage.
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 25f2a20 to 3b2a347 Compare November 25, 2024 10:24
@graphite-app graphite-app bot merged commit 3b2a347 into main Nov 25, 2024
19 checks passed
@graphite-app graphite-app bot deleted the 11-04-test_transformer_script_to_amend_babel_fixtures branch November 25, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants