refactor(transformer): helper loader methods take Span
#7304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
This was referenced Nov 15, 2024
This was referenced Nov 15, 2024
overlookmotel
changed the title
SpanSpan
CodSpeed Performance ReportMerging #7304 will not alter performanceComparing Summary
|
Merge activity
|
Boshen
force-pushed
the
11-15-feat_traverse_add_methods_for_creating_expression_identifier_s
branch
from
6e7d767 to
fcd6c3d
Compare
Boshen
pushed a commit
that referenced
this pull request
Nov 16, 2024
Boshen
force-pushed
the
11-15-refactor_transformer_helper_load_methods_take_span_
branch
from
9028609 to
d13195c
Compare
Boshen
force-pushed
the
11-15-feat_traverse_add_methods_for_creating_expression_identifier_s
branch
from
fcd6c3d to
faf8dde
Compare
Boshen
force-pushed
the
11-15-refactor_transformer_helper_load_methods_take_span_
branch
from
d13195c to
4acf2db
Compare
Base automatically changed from
11-15-feat_traverse_add_methods_for_creating_expression_identifier_s
to
main
November 16, 2024 05:44
graphite-app
bot
deleted the
11-15-refactor_transformer_helper_load_methods_take_span_
branch
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformCtx::helper_callandTransformCtx::helper_call_exprtake aSpan. Sometimes the helper call replaces some original code, and should have the same span as the original code.