Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(transformer): use AstBuilder::vec_from_array #7333

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 17, 2024

Use AstBuilder::vec_from_array introduced in #7331 in the transformer, in place of creating a Vec with Vec::with_capacity and then pushing values to it.

Copy link

graphite-app bot commented Nov 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 17, 2024
@overlookmotel overlookmotel changed the title refactor(transformer): use AstBuilder::vec_from_array perf(transformer): use AstBuilder::vec_from_array Nov 17, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 17, 2024 19:46
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 17, 2024
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #7333 will not alter performance

Comparing 11-17-refactor_transformer_use_astbuilder_vec_from_array_ (510b95d) with main (1938a1d)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel removed the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 17, 2024
@overlookmotel
Copy link
Contributor Author

bench

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 18, 2024
Copy link

graphite-app bot commented Nov 18, 2024

Merge activity

Use `AstBuilder::vec_from_array` introduced in #7331 in the transformer, in place of creating a `Vec` with `Vec::with_capacity` and then pushing values to it.
@Boshen Boshen force-pushed the 11-17-feat_allocator_introduce_vec_from_array_in_ branch from f34b427 to 39afb48 Compare November 18, 2024 02:35
@Boshen Boshen force-pushed the 11-17-refactor_transformer_use_astbuilder_vec_from_array_ branch from 94f3e0a to 510b95d Compare November 18, 2024 02:36
Base automatically changed from 11-17-feat_allocator_introduce_vec_from_array_in_ to main November 18, 2024 02:42
@graphite-app graphite-app bot merged commit 510b95d into main Nov 18, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-17-refactor_transformer_use_astbuilder_vec_from_array_ branch November 18, 2024 02:47
@overlookmotel
Copy link
Contributor Author

Ping @Dunqing. Just so you're aware this API exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant