Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traverse): add methods to BoundIdentifier + MaybeBoundIdentifier to create SimpleAssignmentTargets #7418

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 22, 2024

We had methods to create AssignmentTargets. Add methods to create SimpleAssignmentTargets too.

Copy link

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 22, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 22, 2024 10:53
@overlookmotel overlookmotel changed the base branch from 11-22-docs_traverse_fix_docs_for_boundidentifier_maybeboundidentifier_ to graphite-base/7418 November 22, 2024 10:58
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #7418 will not alter performance

Comparing 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s (971c91a) with main (eb39a50)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s branch from 1a6116b to 5e497b3 Compare November 22, 2024 11:04
@overlookmotel overlookmotel changed the base branch from graphite-base/7418 to main November 22, 2024 11:05
@overlookmotel overlookmotel force-pushed the 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s branch from 5e497b3 to bc85b2b Compare November 22, 2024 11:05
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 22, 2024
Copy link
Member

Boshen commented Nov 22, 2024

Merge activity

  • Nov 22, 7:30 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 22, 7:30 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 22, 7:36 AM EST: A user merged this pull request with the Graphite merge queue.

…ier` to create `SimpleAssignmentTarget`s (#7418)

We had methods to create `AssignmentTarget`s. Add methods to create `SimpleAssignmentTarget`s too.
@Boshen Boshen force-pushed the 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s branch from bc85b2b to 971c91a Compare November 22, 2024 12:31
@graphite-app graphite-app bot merged commit 971c91a into main Nov 22, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s branch November 22, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants