Revert "[sled-agent] PUT zones doesn't create datasets (#7006)" #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 81c808c.
We cannot yet rely on
omicron-datasets.jsonexisting, because old systems need new blueprints to receive thatconfiguration file. Unfortunately, systems exist (e.g. dogfood) which have not had blueprints created that contain
necessary datasets - as a result, the original PR would prevent cold boot from functioning properly, as the lack of
omicron-datasets.jsonwould prevent zones from being initialized.By reverting this PR, zones should be able to launch during cold boot without an
omicron-datasets.jsonfile once more.