[sled-agent] PUT zones doesn't create datasets (#7006) #7160
+100
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `PUT` zones will now check that datasets exist -- as they should be initialized, with prior calls -- rather than forcefully creating them. This PR checks that datasets exist in the "configuration", rather than querying inventory. Fixes #6991
|
Blocked on #7229 |
|
Chatted with @jgallagher , interestingly, because of all our backwards-compatibility checks, this may not actually be blocked on #7229
https://github.com/oxidecomputer/omicron/blob/main/sled-agent/src/services.rs#L3702-L3710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commentary
This PR re-lands #7006 , which was reverted by #7157.
This should only be merged after a branch for release 12 has been cut.
Old PR message
Calls to
PUTzones will now check that datasets exist -- as they should be initialized, with prior calls -- rather than forcefully creating them.This PR checks that datasets exist in the "configuration", rather than querying inventory.
Fixes #6991