Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging in reduce task #175

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Logging in reduce task #175

merged 4 commits into from
Jun 29, 2022

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jun 28, 2022 •
edited by adzialocha
Loading

Debug logging in reduce task.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #175 (69329a6) into main (e2a5e2e) will decrease coverage by 0.28%.
The diff coverage is 41.66%.

❗ Current head 69329a6 differs from pull request most recent head bb7baff. Consider uploading reports for the commit bb7baff to get more accurate results

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   90.80%   90.51%   -0.29%     
==========================================
  Files          43       43              
  Lines        2860     2878      +18     
==========================================
+ Hits         2597     2605       +8     
- Misses        263      273      +10
Impacted Files Coverage Δ
aquadoggo/src/materializer/tasks/reduce.rs 89.77% <41.66%> (-5.80%) ⬇️
aquadoggo/src/materializer/worker.rs 90.45% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a5e2e...bb7baff. Read the comment docs.

@sandreae sandreae marked this pull request as ready for review June 28, 2022 09:54
@sandreae sandreae mentioned this pull request Jun 28, 2022
Merged
4 tasks
@adzialocha adzialocha changed the base branch from development to main June 28, 2022 21:30
@sandreae sandreae requested a review from adzialocha June 28, 2022 21:53
@adzialocha adzialocha merged commit 07235c8 into main Jun 29, 2022
@adzialocha adzialocha deleted the logging-in-reduce-task branch June 29, 2022 14:01
adzialocha added a commit that referenced this pull request Jul 1, 2022
@adzialocha
Merge branch 'main' into schema-provider
78a5c9b 
* main:
  Update CHANGELOG.md
  Refactor replication API (#184)
  GraphQL replication client (#137)
  Update aquadoggo to v0.3.0 in aquadoggo_cli
  v0.3.0
  Prepare CHANGELOG for v0.3.0 release
  Commit Cargo.lock
  p2panda-rs v0.4.0
  Remove unused import
  Update naming in `publishEntry` query and `nextEntryArgs` response (#181)
  Fix bug when materialising documents containing (non-existent) pinned relations (#177)
  Logging in reduce task (#175)
  Refactor test db creation (#176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adzialocha adzialocha adzialocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandreae @adzialocha