Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test db creation #176

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Refactor test db creation #176

merged 4 commits into from
Jun 29, 2022

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jun 28, 2022

Small bit of refactoring:

  • Introduced send_to_store() method which helps in publishing operations encoded on entries to the store

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae changed the base branch from main to development June 28, 2022 09:50
@sandreae sandreae marked this pull request as ready for review June 28, 2022 09:54
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #176 (9955c4a) into main (a1e5973) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   90.80%   90.82%   +0.02%     
==========================================
  Files          43       43              
  Lines        2860     2867       +7     
==========================================
+ Hits         2597     2604       +7     
  Misses        263      263              
Impacted Files Coverage Δ
aquadoggo/src/db/stores/test_utils.rs 97.77% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e5973...9955c4a. Read the comment docs.

@adzialocha
Copy link
Member

This definitely deserves a changelog entry ✌️

@adzialocha adzialocha changed the base branch from development to main June 28, 2022 21:30
@sandreae sandreae requested a review from adzialocha June 28, 2022 21:52
@sandreae
Copy link
Member Author

Sorry, I'm gunna merge this without review as I'm about to make changes to the same code in the replication PR. Hope that's ok, as it's only refactoring I thought it would be.

@sandreae sandreae merged commit 4b9f18f into main Jun 29, 2022
@adzialocha adzialocha deleted the refactor-test-db-creation branch June 29, 2022 14:02
adzialocha added a commit that referenced this pull request Jul 1, 2022
* main:
  Update CHANGELOG.md
  Refactor replication API (#184)
  GraphQL replication client (#137)
  Update aquadoggo to v0.3.0 in aquadoggo_cli
  v0.3.0
  Prepare CHANGELOG for v0.3.0 release
  Commit Cargo.lock
  p2panda-rs v0.4.0
  Remove unused import
  Update naming in `publishEntry` query and `nextEntryArgs` response (#181)
  Fix bug when materialising documents containing (non-existent) pinned relations (#177)
  Logging in reduce task (#175)
  Refactor test db creation (#176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants