Refactor test db creation #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreae
force-pushed
the
refactor-test-db-creation
branch
from
114ec38
to
9fc64d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 90.80% 90.82% +0.02%
==========================================
Files 43 43
Lines 2860 2867 +7
==========================================
+ Hits 2597 2604 +7
Misses 263 263
Continue to review full report at Codecov.
|
4 tasks
|
This definitely deserves a changelog entry ✌️ |
|
Sorry, I'm gunna merge this without review as I'm about to make changes to the same code in the replication PR. Hope that's ok, as it's only refactoring I thought it would be. |
adzialocha
added a commit
that referenced
this pull request
Jul 1, 2022
* main: Update CHANGELOG.md Refactor replication API (#184) GraphQL replication client (#137) Update aquadoggo to v0.3.0 in aquadoggo_cli v0.3.0 Prepare CHANGELOG for v0.3.0 release Commit Cargo.lock p2panda-rs v0.4.0 Remove unused import Update naming in `publishEntry` query and `nextEntryArgs` response (#181) Fix bug when materialising documents containing (non-existent) pinned relations (#177) Logging in reduce task (#175) Refactor test db creation (#176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bit of refactoring:
send_to_store()method which helps in publishing operations encoded on entries to the store📋 Checklist
CHANGELOG.md