Untagged operation format & schema validation #235

sandreae · 2022-08-12T12:35:03Z

Integrate new API for the "monster" p2panda/p2panda#415 including some changes needed for this PR here p2panda/p2panda#434

Next up

there is still this mysterious GraphQL issue: async-graphql panics when DocumentId scalar is not included in nextArgs query args definition #242

📋 Checklist

Add tests that cover your changes
Add this PR to the Unreleased section in CHANGELOG.md
Link this PR to any issues it closes
New files contain a SPDX license header

…d TODO

…eration

sandreae · 2022-08-19T15:17:59Z

On the off chance it's related, I'm gunna pull the e2e test out of this PR into it's own. 👍

adzialocha · 2022-08-19T15:18:54Z

On the off chance it's related, I'm gunna pull the e2e test out of this PR into it's own. +1

Hmn .. none of these errors are related to the e2e test

sandreae · 2022-08-19T15:21:21Z

On the off chance it's related, I'm gunna pull the e2e test out of this PR into it's own. +1

Hmn .. none of these errors are related to the e2e test

~~I know, but it seems like a new variable (running Node directly) which is worth removing 👍~~ I tried, it didn't seem to help

sandreae · 2022-08-19T15:24:15Z

Booo, I just got similar errors:


failures:

---- graphql::client::dynamic_query::test::single_query stdout ----
-------------- TEST START --------------
thread 'graphql::client::dynamic_query::test::single_query' panicked at 'assertion failed: `(left == right)`
  left: `Null`,
 right: `Object({Name("byViewId"): Object({Name("fields"): Object({Name("bool"): Boolean(true)})}), Name("byDocumentId"): Object({Name("fields"): Object({Name("bool"): Boolean(true)})})})`: [
    ServerError {
        message: "Unknown field \"schema_name_0020ed39a1975cc0dfb369cb54bcd662ebf29c4563af22cfc8feb578eb5ba58f9b13\" on type \"QueryRoot\".",
        locations: [
            Pos(2:17),
        ],
        path: [],
        extensions: None,
    },
    ServerError {
        message: "Unknown field \"schema_name_0020ed39a1975cc0dfb369cb54bcd662ebf29c4563af22cfc8feb578eb5ba58f9b13\" on type \"QueryRoot\".",
        locations: [
            Pos(5:17),
        ],
        path: [],
        extensions: None,
    },
]', aquadoggo/src/graphql/client/dynamic_query.rs:440:13

---- graphql::client::dynamic_types::tests::application_schema_container_type stdout ----
-------------- TEST START --------------
thread 'graphql::client::dynamic_types::tests::application_schema_container_type' panicked at 'assertion failed: `(left == right)`
  left: `Object({Name("schema"): Null})`,
 right: `Object({Name("schema"): Object({Name("kind"): String("OBJECT"), Name("name"): String("schema_name_0020901c9ab87fa9da3e44ce56a507bcd0ff5075354bb3acdf663bbe540459a11610"), Name("description"): String("test schema description"), Name("fields"): List([Object({Name("name"): String("meta"), Name("type"): Object({Name("name"): String("DocumentMeta")})}), Object({Name("name"): String("fields"), Name("type"): Object({Name("name"): String("schema_name_0020901c9ab87fa9da3e44ce56a507bcd0ff5075354bb3acdf663bbe540459a11610Fields")})})])})})`: 
[]
', aquadoggo/src/graphql/client/dynamic_types/tests.rs:134:9

---- graphql::replication::query::tests::entries_newer_than_seq_num_cursor::case_3_some_edges_no_next_page stdout ----
-------------- TEST START --------------
thread 'graphql::replication::query::tests::entries_newer_than_seq_num_cursor::case_3_some_edges_no_next_page' panicked at 'Send to store: Custom("Entry's claimed log id of 1 does not match existing log id of 0 for given author and document")', /home/sandreae/.cargo/git/checkouts/p2panda-fb44b351afe3c13e/103a133/p2panda-rs/src/test_utils/db/test_db.rs:250:26


failures:
    graphql::client::dynamic_query::test::single_query
    graphql::client::dynamic_types::tests::application_schema_container_type
    graphql::replication::query::tests::entries_newer_than_seq_num_cursor::case_3_some_edges_no_next_page

Which vanished on a second run 😭

sandreae · 2022-08-19T15:24:54Z

(That was after removing the e2e test)

sandreae · 2022-08-19T15:29:32Z

When it happens, it seems likely graphql::client::dynamic_query::test::single_query will be in there.

sandreae · 2022-08-19T15:34:07Z

Hmm, every test I've seen fail has been using the graphql interface.

sandreae · 2022-08-19T16:13:58Z

Maybe increasing the broadcast::channel capacity higher that 16 is making a difference....

sandreae · 2022-08-19T16:19:22Z

Maybe increasing the broadcast::channel capacity higher that 16 is making a difference....

Fingers crossed, I think that was it. 16 seemed to be too low.

Also in the e2e tests, when running the tests with RUST_LOG=trace we need to wait longer after publishing an entry for the node to process it.

…ports

adzialocha · 2022-08-19T17:19:35Z

aquadoggo/src/tests.rs

@@ -0,0 +1,402 @@
+// SPDX-License-Identifier: AGPL-3.0-or-later
+
+//! E2E test and mini-tutorial for aquadoggo.


This is very beautiful! 🌹

I've renamed the file to tests.rs as the place of the file in the root already indicates that it is "end-to-end".

adzialocha

Yesssssss, this is the final step and it looks great! おつかれさまでした!

I think all other things can be easily tackled in sub-sequent steps, for now its just important that we have everything in place ✨

Small bummer: I continue having some failing cases when running tests .. much more rare now though. I propose fixing this in another PR though as this is not the scope of this one. I changed the target branch to development for now 👍

---- graphql::client::dynamic_types::tests::application_schema_fields_type stdout ----
-------------- TEST START --------------
thread 'graphql::client::dynamic_types::tests::application_schema_fields_type' panicked at 'assertion failed: `(left == right)`
  left: `Object({Name("schemaFields"): Null})`,
 right: `Object({Name("schemaFields"): Object({Name("description"): String("Data fields available on documents of this schema."), Name("fields"): List([Object({Name("name"): String("bool_field"), Name("type"): Object({Name("kind"): String("SCALAR"), Name("name"): String("Boolean")})}), Object({Name("name"): String("list_field"), Name("type"): Object({Name("kind"): String("LIST"), Name("name"): Null})}), Object({Name("name"): String("relation_field"), Name("type"): Object({Name("kind"): String("OBJECT"), Name("name"): String("schema_definition_v1")})})])})})`:
[]
', aquadoggo/src/graphql/client/dynamic_types/tests.rs:216:9

.. and the good old:

thread 'graphql::client::dynamic_query::test::single_query' panicked at 'assertion failed: `(left == right)`
  left: `Null`,
 right: `Object({Name("byViewId"): Object({Name("fields"): Object({Name("bool"): Boolean(true)})}), Name("byDocumentId"): Object({Name("fields"): Object({Name("bool"): Boolean(true)})})})`: [
    ServerError {
        message: "Unknown field \"schema_name_0020b26f0944a65929c85f9008dfe0de57b3a6b992e398b421a03d5f405964b89617\" on type \"QueryRoot\".",
        locations: [
            Pos(2:17),
        ],
        path: [],
        extensions: None,
    },
    ServerError {
        message: "Unknown field \"schema_name_0020b26f0944a65929c85f9008dfe0de57b3a6b992e398b421a03d5f405964b89617\" on type \"QueryRoot\".",
        locations: [
            Pos(5:17),
        ],
        path: [],
        extensions: None,
    },
]', aquadoggo/src/graphql/client/dynamic_query.rs:440:13

sandreae · 2022-08-19T18:20:55Z

👏👏👏👏🥳🥳🥳

* development: clippy Use `DocumentStore` trait from p2panda rs (#249) Corrections in e2e test Untagged operation format & schema validation (#235)

* development: Friendly names for scalars in GraphQL schema (#231) clippy Use `DocumentStore` trait from p2panda rs (#249) Corrections in e2e test Untagged operation format & schema validation (#235)

* development: Fix GraphQL responses (#236) Friendly names for scalars in GraphQL schema (#231) clippy Use `DocumentStore` trait from p2panda rs (#249) Corrections in e2e test Untagged operation format & schema validation (#235)

* development: Rename `nextEntryArgs` and `publishEntry` (#232) Fix GraphQL responses (#236) Friendly names for scalars in GraphQL schema (#231) clippy Use `DocumentStore` trait from p2panda rs (#249) Corrections in e2e test Untagged operation format & schema validation (#235)

sandreae added 30 commits August 11, 2022 12:10

Use p2panda_rs schema-refactoring branch

e322696

Fix imports, renaming and simple method refactoring

58cc383

Use local p2panda-rs

63b3777

WIP: Refactor StorageEntry

7a94944

Use OperationBuilder in tests

9dec52e

Operation field fixes in store tests

8ba7265

Refactor domain methods and tests (for now pass Schema into publish)

a6fe6e2

Comment out publishing entry and operation in replication service, ad…

c54690a

…d TODO

Fixes in replication response

b1fa628

Bool = Boolean

e0f5df9

Test fixes and TODOs

0c752ac

Test imports and updates

16ae867

Rework domain module, pass more into publish entry

90897ab

Import new traits

12e1f11

Int = Integer

8bca98a

Remove tests which need big refactor

ffaf2b4

Refactor insert_entry() to accept entry, encoded_entry and encoded_op…

049df4a

…eration

Update insert_operation params in domain

3a3672f

Pass link params as tuple containing references

e6dfa4b

Imports and api changes in validation

1b14819

Comment out tests which need refactoring in service

ef9d2a9

Type changes and imports in dependency task

1200f00

Missed a couple of things in dependency task

11c4dc3

updates in reduce task

786f7ae

Update operation creation api in domain tests

b951569

Missed something...

88f26c3

Imports and api updates in response

2c014b3

Improve byte conversion

8d5a299

Bool = Boolean

8f18417

Implement operation traits changes

51f457d

sandreae added 2 commits August 19, 2022 17:17

Wait a little longer after publish in e2e test

986d8af

Increase broadcast channel capacity

084e25f

sandreae marked this pull request as ready for review August 19, 2022 16:19

sandreae and others added 6 commits August 19, 2022 17:22

Fix typos

f0aeaae

Update CHANGELOG

bb6a730

Fix clippy errors

c324c0c

Rename e2e_tests, just to tests, its on lib-level already, fix lib ex…

9428cf8

…ports

Remove super-level import

c4a8ae9

Minor formatting changes

69b73c0

adzialocha reviewed Aug 19, 2022

View reviewed changes

Check grammar in e2e test

f3cd7f0

adzialocha self-requested a review August 19, 2022 17:36

adzialocha approved these changes Aug 19, 2022

View reviewed changes

adzialocha changed the base branch from main to development August 19, 2022 17:48

sandreae merged commit f95cf83 into development Aug 19, 2022

adzialocha added a commit that referenced this pull request Aug 22, 2022

Merge branch 'development' into gql-scalar-names

469edf4

* development: clippy Use `DocumentStore` trait from p2panda rs (#249) Corrections in e2e test Untagged operation format & schema validation (#235)

adzialocha deleted the the-monster-refactor-again branch August 22, 2022 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Untagged operation format & schema validation #235

Untagged operation format & schema validation #235

sandreae commented Aug 12, 2022 •

edited

Loading

sandreae commented Aug 19, 2022

adzialocha commented Aug 19, 2022

sandreae commented Aug 19, 2022 •

edited

Loading

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022 •

edited

Loading

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022

adzialocha Aug 19, 2022

adzialocha left a comment •

edited

Loading

sandreae commented Aug 19, 2022

		@@ -0,0 +1,402 @@
		// SPDX-License-Identifier: AGPL-3.0-or-later

		//! E2E test and mini-tutorial for aquadoggo.

Untagged operation format & schema validation #235

Untagged operation format & schema validation #235

Conversation

sandreae commented Aug 12, 2022 • edited Loading

Next up

📋 Checklist

sandreae commented Aug 19, 2022

adzialocha commented Aug 19, 2022

sandreae commented Aug 19, 2022 • edited Loading

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022 • edited Loading

sandreae commented Aug 19, 2022

sandreae commented Aug 19, 2022

adzialocha Aug 19, 2022

Choose a reason for hiding this comment

adzialocha left a comment • edited Loading

Choose a reason for hiding this comment

sandreae commented Aug 19, 2022

sandreae commented Aug 12, 2022 •

edited

Loading

sandreae commented Aug 19, 2022 •

edited

Loading

sandreae commented Aug 19, 2022 •

edited

Loading

adzialocha left a comment •

edited

Loading