Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GraphQL responses #236

Merged
merged 8 commits into from
Aug 22, 2022
Merged

Fix GraphQL responses #236

merged 8 commits into from
Aug 22, 2022

Conversation

cafca
Copy link
Member

@cafca cafca commented Aug 12, 2022

Closes #234 and #233

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #236 (95b8b07) into main (1f15d06) will decrease coverage by 0.07%.
The diff coverage is 73.07%.

❗ Current head 95b8b07 differs from pull request most recent head 2e317cd. Consider uploading reports for the commit 2e317cd to get more accurate results

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   93.83%   93.75%   -0.08%     
==========================================
  Files          58       58              
  Lines        4801     4853      +52     
==========================================
+ Hits         4505     4550      +45     
- Misses        296      303       +7     
Impacted Files Coverage Δ
.../src/graphql/client/dynamic_types/document_meta.rs 71.42% <40.00%> (+8.92%) ⬆️
aquadoggo/src/graphql/client/dynamic_query.rs 90.98% <83.33%> (-0.73%) ⬇️
...rc/graphql/client/dynamic_types/document_fields.rs 100.00% <100.00%> (ø)
aquadoggo/src/http/service.rs 92.30% <100.00%> (+0.20%) ⬆️
aquadoggo/src/materializer/worker.rs 85.99% <0.00%> (-0.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cafca cafca marked this pull request as ready for review August 12, 2022 14:23
@adzialocha adzialocha linked an issue Aug 14, 2022 that may be closed by this pull request
* development:
  Friendly names for scalars in GraphQL schema (#231)
  clippy
  Use `DocumentStore` trait from p2panda rs (#249)
  Corrections in e2e test
  Untagged operation format & schema validation (#235)
@adzialocha adzialocha changed the base branch from main to development August 22, 2022 11:45
@adzialocha adzialocha merged commit 8c0963d into development Aug 22, 2022
@adzialocha adzialocha deleted the fix-gql-schema branch August 22, 2022 11:46
adzialocha added a commit that referenced this pull request Aug 22, 2022
* development:
  Fix GraphQL responses (#236)
  Friendly names for scalars in GraphQL schema (#231)
  clippy
  Use `DocumentStore` trait from p2panda rs (#249)
  Corrections in e2e test
  Untagged operation format & schema validation (#235)
adzialocha added a commit that referenced this pull request Aug 22, 2022
* development:
  Rename `nextEntryArgs` and `publishEntry` (#232)
  Fix GraphQL responses (#236)
  Friendly names for scalars in GraphQL schema (#231)
  clippy
  Use `DocumentStore` trait from p2panda rs (#249)
  Corrections in e2e test
  Untagged operation format & schema validation (#235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants