-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix early document view insertion #413
Conversation
This is compiling (
|
Updating to |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## development #413 +/- ##
===============================================
- Coverage 90.32% 90.25% -0.07%
===============================================
Files 87 87
Lines 8203 8228 +25
===============================================
+ Hits 7409 7426 +17
- Misses 794 802 +8
☔ View full report in Codecov by Sentry. |
* development: (23 commits) Implement `dialer` behaviour (#444) Sort expected results in strategy tests Update CHANGELOG Replicate operations in topo order (#442) Maintain sorted operation indexes (#438) Use fork of `asynchronous-codec` (#440) Ingest check for duplicate entries (#439) Reverse lookup for pinned relations in dependency task (#434) Remove unnecessary exact version pinning in Cargo.toml Make `TaskInput` an enum and other minor clean ups in materialiser (#429) Use `libp2p` `v0.52.0` (#425) Fix race condition when check for existing view ids was too early (#420) Reduce logging verbosity CI: Temporary workaround for Rust compiler bug (#417) Fix early document view insertion (#413) Handle duplicate document view insertions (#410) Decouple p2panda's authentication data types from libp2p's (#408) Remove dead_code attribute in lib Integrate replication manager with networking stack (#387) Implement naive replication protocol (#380) ...
Solution for #407 which implements checking a document has been materialized in a reduce task before inserting a document view into the store. If the document does not exist yet, the task is re-issued, assuming that the document reduce task is already in the queue somewhere.
For safety, and for assisting in identifying potential future bugs, I also introduced a foreign relation constraint onto the
document_id
column indocument_views
table. We don't rely on this being hit in our code though.📋 Checklist
CHANGELOG.md