Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fork of asynchronous-codec #440

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jul 7, 2023

We forked asynchronous-codec in order to introduce a change which fixes a bug we have (being discussed here.

It would be nice to have a test for this, but I've never seen it occur in tests before and am not sure how we could re-produce it.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae linked an issue Jul 7, 2023 that may be closed by this pull request
@sandreae sandreae marked this pull request as ready for review July 7, 2023 08:08
@sandreae sandreae requested a review from adzialocha July 7, 2023 08:08
@adzialocha adzialocha merged commit 11a884c into development Jul 7, 2023
@adzialocha adzialocha deleted the use-asynchronous-codec-fork branch July 7, 2023 11:31
adzialocha added a commit that referenced this pull request Jul 14, 2023
* development: (23 commits)
  Implement `dialer` behaviour (#444)
  Sort expected results in strategy tests
  Update CHANGELOG
  Replicate operations in topo order (#442)
  Maintain sorted operation indexes (#438)
  Use fork of `asynchronous-codec`  (#440)
  Ingest check for duplicate entries (#439)
  Reverse lookup for pinned relations in dependency task (#434)
  Remove unnecessary exact version pinning in Cargo.toml
  Make `TaskInput` an enum and other minor clean ups in materialiser (#429)
  Use `libp2p` `v0.52.0` (#425)
  Fix race condition when check for existing view ids was too early (#420)
  Reduce logging verbosity
  CI: Temporary workaround for Rust compiler bug (#417)
  Fix early document view insertion (#413)
  Handle duplicate document view insertions (#410)
  Decouple p2panda's authentication data types from libp2p's (#408)
  Remove dead_code attribute in lib
  Integrate replication manager with networking stack (#387)
  Implement naive replication protocol (#380)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBOR decoding error in replication connection handler
2 participants