fix: Ensure logging out accounts completes #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The account logout process could fail due to API exceptions; network errors for example, or if the user had already revoked the app's token for that account. This would prevent the rest of the logout process (cleaning database, etc) from completing. Fix this by ignoring network errors during the logout process, and always cleaning up account content in the database. Fix a related issue where a deleted account might be recreated in a partial state if the account's visible position was saved after it was deleted. The recreated account couldn't do anything as it had no tokens, but is very confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The account logout process could fail due to API exceptions; network errors for example, or if the user had already revoked the app's token for that account. This would prevent the rest of the logout process (cleaning database, etc) from completing.
Fix this by ignoring network errors during the logout process, and always cleaning up account content in the database.
Fix a related issue where a deleted account might be recreated in a partial state if the account's visible position was saved after it was deleted. The recreated account couldn't do anything as it had no tokens, but is very confusing.