Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure logging out accounts completes #515

Merged
merged 1 commit into from
Mar 10, 2024
Merged

fix: Ensure logging out accounts completes #515

merged 1 commit into from
Mar 10, 2024

Commits on Mar 10, 2024

  1. fix: Ensure logging out accounts completes

    The account logout process could fail due to API exceptions; network
    errors for example, or if the user had already revoked the app's
    token for that account. This would prevent the rest of the logout
    process (cleaning database, etc) from completing.
    
    Fix this by ignoring network errors during the logout process, and
    always cleaning up account content in the database.
    
    Fix a related issue where a deleted account might be recreated in a
    partial state if the account's visible position was saved after it
    was deleted. The recreated account couldn't do anything as it had no
    tokens, but is very confusing.
    nikclayton committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    3297083 View commit details
    Browse the repository at this point in the history