[QoL] Show message when quick claw is triggered #1684
Conversation
| @@ -775,6 +775,9 @@ export class BypassSpeedChanceModifier extends PokemonHeldItemModifier { | |||
|
|
|||
| if (!bypassSpeed.value && pokemon.randSeedInt(10) < this.getStackCount()) { | |||
| bypassSpeed.value = true; | |||
| if (this.type instanceof ModifierTypes.PokemonHeldItemModifierType && this.type.id === "QUICK_CLAW") { | |||
| pokemon.scene.queueMessage(getPokemonMessage(pokemon, " used its quick claw to move faster!")); | |||
There was a problem hiding this comment.
Should probably be localized
There was a problem hiding this comment.
unless we remove the pokemon prefix coming from the getPokemonMessage() and place the string to a regular i18n locale translation, I dont think this is possible to be localized. please see src/messages.ts
so we have 2 options.
- keep the pokemon prefix but wont be localized
- or remove the pokemon prefix so localization would be possible
There was a problem hiding this comment.
How about you abstract it to make it work?
| pokemon.scene.queueMessage(getPokemonMessage(pokemon, " used its quick claw to move faster!")); | |
| const pokemonPrefix = getPokemonPrefix(pokemon); | |
| pokemon.scene.queueMessage(i18n.t(:itemUse:quickclaw', {pokemon, pokemonPrefix})); |
and then in your translations something like
const de: Record<string, any> = {
"itemUse:quickclaw": "{{pokemonPrefix}} {{pokemon.name}} used its quick claw to move first!"
}(just an inspiration, not actual code)
There was a problem hiding this comment.
the getPokemonPrefix() returns an untranslated text too tho. the whole src/messages.ts does not have translation functionality. i think it needs a separate PR for it
There was a problem hiding this comment.
I agree.
but you can still translate the part you are in control of
There was a problem hiding this comment.
i cant translate only part of it tho, and i wouldnt wanna touch anything from messages.ts on this PR because its being used all over the codebase.
also for reference someone is already working on the translation https://github.com/pagefaultgames/pokerogue/pull/1276/files
There was a problem hiding this comment.
@Tempo-anon it's now up to you
|
@Tempo-anon the foundation for localization support can be found in this PR |
What are the changes?
Why am I doing these changes?
What did change?
Screenshots/Videos
Screen.Recording.2024-06-01.at.6.32.24.PM.mov
How to test the changes?
STARTER_SPECIES_OVERRIDEto a slow pokemon like ShuckleSTARTING_HELD_ITEMS_OVERRIDE: Array<ModifierOverride> = [{name: "QUICK_CLAW", count: 1}];Checklist
npm run test)