useMove + pokemon affix localization

[laeticiapierre]

Issue #1274

EDIT 05/27:
ENG

FR

[CodeTappert]

Could you please make it so that both of them could be suffixes as well?

German for example uses: "Glumanda (Wild)" instead of "Wildes Glumanda" (Wild is the "prefix").

Same with the foe one

[laeticiapierre]

Could you please make it so that both of them could be suffixes as well?

German for example uses: "Glumanda (Wild)" instead of "Wildes Glumanda" (Wild is the "prefix").

Same with the foe one

I've put pokemonPrefix as a parameter name because it's the method name but you can place it wherever you like, feel free to check the french file, it's used that way

[Dakurei]

As it's not at the beginning of a sentence in French, it's a suffix rather than a prefix, so there's no need to capitalize it.
Besides being ugly, it's incorrect 😅

[CodeTappert]

Could you please make it so that both of them could be suffixes as well?
German for example uses: "Glumanda (Wild)" instead of "Wildes Glumanda" (Wild is the "prefix").
Same with the foe one

I've put pokemonPrefix as a parameter name because it's the method name but you can place it wherever you like, feel free to check the french file, it's used that way

Yeah i saw that. So pokemonPrefix is either wildPrefix or foePrefix? Am i understanding this correctly?

[laeticiapierre]

As it's not at the beginning of a sentence in French, it's a suffix rather than a prefix, so there's no need to capitalize it. Besides being ugly, it's incorrect 😅

We could easily fix this by updating the french file and replacing Sauvage with sauvage (same for Ennemi) but traduction is not done everywhere at the moment, there are some places left where we would have "sauvage Tortank [...]" as a sentence and I think it's better to have a capitalized letter at the start of it

EDIT: I found some time to do a bigger rework and the problem is no longer present

[CodeTappert]

German translation. Source (Pokemon Scarlet)

  "wildPokemonPrefix": " (wild)",
  "foePokemonPrefix": " (Gegner)",
  "useMove": "{{pokemonName}}{{pokemonPrefix}} setzt {{moveName}} ein!"

[CodeTappert]

German translation. Source (Pokemon Scarlet)

  "wildPokemonPrefix": " (wild)",
  "foePokemonPrefix": " (Gegner)",
  "useMove": "{{pokemonName}}{{pokemonPrefix}} setzt {{moveName}} ein!"

Just quick update. I updated this again just now so it works even when the prefix is set to an empty string (which i assume is done for our own Pokemon?).

Just added a space in the prefix itself but removed the one in the useMove string

[Adri1]

As "Wild" and "Foe" can be placed either before or after depending on the language (as demonstarted) my opinion is to rename it an "affix". Affix being a the dedicated (and more generalist) term to talk about any addition to a word, either placed before or after it, among others.
https://en.wikipedia.org/wiki/Affix
https://fr.wikipedia.org/wiki/Affixe

Or you can also simply call it an adjective, as "wild" and "foe" are qualifiers of the Pokémon they refer to.

Second opinon, i'd also suggest to add a line beark after "utilise" in the French sentence to put the name of the move below, as it is in English and French versions of older Pokémon games

[wuzhaoqi1015]

Has this issue been merged?

[CodeTappert]

Has this issue been merged?

Not yet. The creator of the issue has not adressed the latest comments or made changes suggestet. It is a "Draft". So we wait

[CodeTappert]

Could you please provide screenshots of the german version? Would love to see if it looks correct

[laeticiapierre]

Could you please provide screenshots of the german version? Would love to see if it looks correct

[CodeTappert]

Could you please provide screenshots of the german version? Would love to see if it looks correct

Thank. You. Looks very good!

[brain-frog]

Sorry this is a product of the delay in further review but since korean is now in locales can you please add that to this PR

[brain-frog]

Looks good, a few things to fix before we can approve

[brain-frog]

please add documentation for this and the above method, reference docs/comments.md for a guide

[laeticiapierre]

Done 👍🏻 (and korean)

[returntoice]

Suggested change

	"wildPokemonWithAffix": "Wild {{pokemonName}}",
	"foePokemonWithAffix": "Foe {{pokemonName}}",
	"useMove": "{{pokemonNameWithAffix}} used {{moveName}}!"
	"wildPokemonWithAffix": "야생 {{pokemonName}}",
	"foePokemonWithAffix": "상대 {{pokemonName}}",
	"useMove": "{{pokemonNameWithAffix}}의 {{moveName}}!"

translated by the official translation(VIII, IX gen)

[flx-sta]

@laeticiapierre please resolve the merge conflicts

Issue Resolved