[Localization] Implement pokemon forms localization

[Kiriox94]

If you want to contribute, please open a PULL REQUEST on my branch

What are the changes?

Localization of pokemon forms in the starter selection menu and in battles

Why am I doing these changes?

So that the whole game can be localized in one day, and also because it was requested here #339

What did change?

The strings for displaying forms are now retrieved from src/locales/{your language}/pokemon-form.ts and no longer raw in the code.

Checklist

• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)

[Adri1]

I created a PR to your branch with French traslations

[Kiriox94]

Thank you for your contribution @returntoice, next time if you could go through a pull request, it would be easier

[returntoice]

Sorry I am not that familiar with the Github system. Is is right that I'd have been better off making a new PR and merging with this PR?

[Kiriox94]

Sorry I am not that familiar with the Github system. Is is right that I'd have been better off making a new PR and merging with this PR?

Yes, making a pull request on my branch would have made it possible to add all the modifications at once, but the result is the same.

[Adri1]

I just pushed a new PR tout your branch to correct a typo in French

[CodeTappert]

Could you please provide some screenshots about where they are used? I am about to provide a PR with the german localization but some form names depend on where they are shown.

[CodeTappert]

Could you please provide some screenshots about where they are used? I am about to provide a PR with the german localization but some form names depend on where they are shown.

For example

needs to be

in german.

But could also be written as for example "Pikachu (Rocker)"

[CodeTappert]

You are missing some forms:

• Deoxys Forms
• Cherrim Forms
• Origin Forms for Palkia, Dialga, Girantina
• Shaymins alternative form
• (if needed the arceus forms)
• Darmanitan trance mode
• The animal spirt forms of Tornadus, Thundurus, Landorus and Enamorus
• Kyurem (White/Black)
• Keldeo Resolutform
• Meloetta Dancingform
• Genesect: Schock Drive, Burn Drive, ChillDrive, Douse Drive
• Furfrou (Natural Form)
• Aegislash (blade/shieldform)
• pumpkaboo (Medium)
• eiscue iceform
• Sinistcha Unremarkable Form. Masterpiece Form
• No localizatiotion for the forms of Lycanroc
• Hoopa (Confined/Unbound)
• Mimikyu (Disguised/Busted)
• Wishiwashi: Schoolform/Soloform
• Silvally Forms
• Necrozma: Fusion with Solgaleo, Fusion with Lunala, Ultra Necrozma
• Cramorant: Gulping Form/Gorging Form
• Morpeko: Full-Belly Mode, Hangry Mode
• Zacian: Hero of Many Battles / Crowned Sword
• Zamazenta: Hero of Many Battles / Crowned Shield
• Calyrex: Ice Rider Calyrex / Shadow Rider Carylex
• Palafin: Heroform
• Ogerpon: Teal Mask/Wellspring Mask/Hearthflame Mask/Cornerstone Mask
• Terapagos: Terastal Form/Stellarform
• Partner Evee, Partner Pikachu
• Pikachu with the Caps
• Toxtricity: Highform/Lowform
• Urshifu: Rapid Style Strike, Single Style Strike
• Ursaluna: Bloodmoon form
  Source (in german): https://www.pokewiki.de/Pok%C3%A9mon_mit_verschiedenen_Formen

[CodeTappert]

German PR is here: Kiriox94#4

[returntoice]

for canceling

[Kiriox94]

Why does everyone cancel their review?

[EnochG1]

Maybe they approve after you merge main branch.
You can do it if you approve and merge my PR.
Kiriox94#8

[Kiriox94]

Yes, I'm just trying it out on my end to make sure everything works, then I'll merge your pr

[EnochG1]

@40chyan
@returntoice
@josericardo-fo
@flx-sta
@InnocentGameDev
@Adri1
@bennybroseph

Hi,
I and Kiriox94 resolved conflict and merge 'main' into branch.
Please check and approve if 'File changed' has no problem. (When you have a time.)

[mercurius-00]

fix typo

[flx-sta]

[...]
@ flx-sta
[...]
Hi,
I and Kiriox94 resolved conflict and merge 'main' into branch.
Please check and approve if 'File changed' has no problem. (When you have a time.)

I wasn't involved at all in this ticket, so I'll leave you guys at it

[AsdarDevelops]

Reverted some changes I made to the Vivillion's forms. Otherwise "ES" looks good.

[EnochG1]

@Kiriox94
Could you apply InnocentGameDev's suggestion?

[f-fsantos]

@Kiriox94 can you confirm that both the UI and all the keys were tested?

[Kiriox94]

@Kiriox94 can you confirm that both the UI and all the keys were tested?

Yes

[EnochG1]

@f-fsantos
I checked code you said and there's no problem.
The reason for removing form.formName is that
it was separated by each form (for localization of form name also, including position of name.)

// As-is
      case SpeciesFormKey.MEGA:
      case SpeciesFormKey.PRIMAL:
      case SpeciesFormKey.ETERNAMAX:
        return `${form.formName} ${this.name}`; // this code covers 3 forms
      case SpeciesFormKey.MEGA_X:
        return `Mega ${this.name} X`;
      case SpeciesFormKey.MEGA_Y:
        return `Mega ${this.name} Y`;
      default:
        if (form.formKey.indexOf(SpeciesFormKey.GIGANTAMAX) > -1) {
          return `G-Max ${this.name}`;
        }
      }

// TO-BE
      case SpeciesFormKey.MEGA: // each form name separated
        return i18next.t("pokemonForm:mega", {pokemonName: this.name});
      case SpeciesFormKey.PRIMAL:
        return i18next.t("pokemonForm:primal", {pokemonName: this.name});
      case SpeciesFormKey.ETERNAMAX:
        return i18next.t("pokemonForm:eternamax", {pokemonName: this.name});
      case SpeciesFormKey.MEGA_X:
        return i18next.t("pokemonForm:megax", {pokemonName: this.name});
      case SpeciesFormKey.MEGA_Y:
        return i18next.t("pokemonForm:megay", {pokemonName: this.name});
      default:
        if (form.formKey.indexOf(SpeciesFormKey.GIGANTAMAX) > -1) {
          return i18next.t("pokemonForm:gigantamax", {pokemonName: this.name});
        }
      }

Here's my test screenshot in this branch. (English / Franch)

En	Fr

[EnochG1]

@f-fsantos
And I tested this part, too.

        const speciesName = Species[species.speciesId].toLowerCase().split("_");
        for (let i = 1; i < speciesName?.length; i++) {
          speciesName[i] = speciesName[i].charAt(0).toUpperCase() + speciesName[i].substring(1);
        }

        if (species.speciesId === Species.ARCEUS) {
          this.pokemonFormText.setText(i18next.t(`pokemonInfo:Type.${formText?.join("").toUpperCase()}`));
        } else {
          this.pokemonFormText.setText(formText?.join("") ? i18next.t(`pokemonForm:${speciesName.join("")}${formText.join("")}`) : "");
        }

En	Fr

[CodeTappert]

change to megaX

[CodeTappert]

change to megaY

[CodeTappert]

Add:

• deoxysNormal
• shayminLand
• giratinaAltered
• tornadusIncarnate
• thundurusIncarnate
• landorusIncarnate
• keldeoOrdinary
• meloettaAria
• morpekoFullBelly
• zacianHeroOfManyBattles
• zamazentaHeroOfManyBattles
• enamorusIncarnate
• miraidonUltimateMode
• miraidonLowPowerMode
• miraidonDriveMode
• miraidonAquaticMode
• miraidonGlideMode
• koraidonApexBuild
• koraidonLimitedBuild
• koraidonSprintingBuild
• koraidonSwimmingBuild
• koraidonGlidingBuild

[CodeTappert]

change to

import { pokemonForm } from "./pokemon-form";