Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] Add localization pokemon fainted (Addition of #1276) #1705

Closed
wants to merge 19 commits into from
Closed

[Localization] Add localization pokemon fainted (Addition of #1276) #1705

wants to merge 19 commits into from

Conversation

Ohmry
Copy link
Contributor

@Ohmry Ohmry commented Jun 1, 2024

What are the changes?

Add localization for pokemon fainted. It is addition of #1276

Why am I doing these changes?

It needs to translate of pokemon fainted

What did change?

  • Change queueMessage to i18next.t("battle:fainted") from just "fainted" in phase.ts

Screenshots/Videos

English

image

Korean

image

Other languages (in example Deutsch)

image

How to test the changes?

  • Checkout this PR
  • Change language

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

laeticiapierre and others added 12 commits May 23, 2024 10:03
@laeticiapierre
useMove + pokemonPrefix localization
3d07428
@laeticiapierre
Merge branch 'main' into issue/1274
821f9be 
# Conflicts:
#	src/locales/en/battle.ts
#	src/locales/es/battle.ts
#	src/locales/it/battle.ts
#	src/locales/pt_BR/battle.ts
#	src/locales/zh_CN/battle.ts
#	src/messages.ts
#	src/phases.ts
@laeticiapierre
Rename prefix to affix + line break fr
7796643
@laeticiapierre
getPokemonAffix to getPokemonNameWithAffix + remove space + replace
44adc71
@laeticiapierre
Better getPokemonNameWithAffix switch
8dd4e0b
@laeticiapierre
Merge branch 'main' into issue/1274
4b347e1
@laeticiapierre
Ko locale + fix es locale
b17fc39
@laeticiapierre
Doc getPokemonNameWithAffix + getPokemonMessage + fix
03a7888
@laeticiapierre
Ko translate / missing weather changes
0879606
@laeticiapierre
Merge branch 'main' into issue/1274
5aa363d 
# Conflicts:
#	src/locales/de/battle.ts
#	src/locales/en/battle.ts
#	src/locales/es/battle.ts
#	src/locales/fr/battle.ts
#	src/locales/it/battle.ts
#	src/locales/pt_BR/battle.ts
#	src/locales/zh_CN/battle.ts
#	src/locales/zh_TW/battle.ts
@laeticiapierre
Fix conflicts getPokemonPrefix
76fe685
@Ohmry
[Localization] Add localization of pokemon painted (Addition of pagef…
2d2807f 
…aultgames#1276)
@Madmadness65 Madmadness65 added the Localization Provides or updates translation efforts label Jun 1, 2024
@Ohmry
Copy link
Contributor Author

Ohmry commented Jun 6, 2024

@bennybroseph
Hi, could you please check this PR?

I transalated to Korean of useMove and fainted. and I created these in other languages too in English. because I hope to help that other translators let know to exists things needs to localize.

@Ohmry Ohmry closed this Jun 8, 2024
@Ohmry Ohmry deleted the localization/addition-of-1276 branch June 8, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeTappert CodeTappert CodeTappert left review comments

Assignees
No one assigned
Labels
Localization Provides or updates translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ohmry @CodeTappert @Madmadness65 @laeticiapierre