Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Epic Drifblim using Drifloon sprite #1788

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

chaosgrimmon
Copy link
Collaborator

What are the changes?

Epic shiny Drifblim gets a perfectly functional animated backsprite, and stops using incorrectly-sized slices of epic Drifloon.

Why am I doing these changes?

There have been so many reports of this I swear.
image

What did change?

2, means to "use the 426_3.png provided", which is the stray Drifloon sprite.
1, instead, tells it to literally just recolor the default Drifblim sprite, the way it does perfectly well for its rare variant.

Screenshots/Videos

Before:
image
After:
image

How to test the changes?

overrides.ts can set a SHINY=true, VARIANT=2 Species.DRIFBLIM as your first starter.

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@chaosgrimmon
Copy link
Collaborator Author

chaosgrimmon commented Jun 4, 2024

Frankly I have no idea why pokemon/variant/back/426_3.png exists. Obviously the numbering is off by one, but even then, the colours already match, so it doesn't seem to add any detail that isn't already in Drifloon's epic variant.

It's not an inexplicably load-bearing TF2!coconut.jpg or anything either, because I deleted it without so much as a console warning.
The #artist backlog might have more details, but I don't have access to those, so 🤷

Copy link
Collaborator

@Tempo-anon Tempo-anon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

426_3 was added by Sam

@Tempo-anon Tempo-anon merged commit 7da8bdf into pagefaultgames:main Jun 4, 2024
3 checks passed
Korwai pushed a commit to Korwai/pokerogue that referenced this pull request Jun 14, 2024
@chaosgrimmon chaosgrimmon deleted the patch-1 branch June 14, 2024 15:30
SavGRY pushed a commit to SavGRY/pokerogue that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants