Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc/Sprite] Clean up extra Drifblim-related files #3371

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

chaosgrimmon
Copy link
Collaborator

What are the changes?

Deletes files that the game doeesn't use and the user shouldn't ever receive.

Why am I doing these changes?

The files don't do anything anymore. I told the game to stop using them in #1788 and though I wasn't sure back then if removing them would cause issues, I no longer have those compunctions.

What did change?

Removes files that the game does not use.

Screenshots/Videos

Does not affect the user experience.

After

image

How to test the changes?

Overrides could be used to ensure epic Drifblim's back animation continues to be an epic Drifblim and not a Drifloon with the wrong animation file.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
    - [] Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
      - [] Are the changes visual?
      ~~ - [] Have I provided screenshots/videos of the changes?~~

@Madmadness65 Madmadness65 added the Sprite/Animation For when graphics are incorrect label Aug 6, 2024
@Tempo-anon Tempo-anon merged commit ed1605d into pagefaultgames:beta Aug 6, 2024
4 checks passed
@chaosgrimmon chaosgrimmon deleted the cleanup-drifblim branch August 29, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprite/Animation For when graphics are incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants