[Ability] Implement Illusion

[PyGaVS]

What are the changes?

Adding illusion ability, works with fusion also

Why am I doing these changes?

It's missing

What did change?

-Added PreSummonAbAttr class as ability attribute.
-Illusion uses the appearance of the last conscious and available Pokémon in the party (ignoring itself), including :
Species, Form, Shininess, Pokeball, Gender
-If We encounter a wild Zorua/Zoroak he will use the illusion of a pokemon in the Abyss Biome. Depending on Zorua or Zoroark level the illusion will be evolved or not.
-If we encounter a boss Zoroark he will use the illusion of Entei, Suicune or Raiku like in the original game.
-The class pokemon has a new attribute illusion.
-A pokemon with illusion can use illusion one time per battle like in the original game.
-After a battle, the pokemon can use illusion again.
-The AI move choice will be affected by the illusion.
-The type will always be displayed as the Pokémon it is disguised as, even when affected by Soak etc.
-The illusion will disappear if the Pokemon has its ability changed or suppressed.
-Pokemon cannot transform into a Pokémon that is disguised by Illusion.
-Pokémon that are disguised by Illusion cannot Transform.
-Illusion will not activate if the last conscious Pokémon is a Terastallized Ogerpon or Terapagos.

Screenshots/Videos

https://discord.com/channels/1125469663833370665/1176874654015684739/1257835032647831682
https://discord.com/channels/1125469663833370665/1176874654015684739/1257864381937619045
https://discord.com/channels/1125469663833370665/1176874654015684739/1257865512801538059
https://discord.com/channels/1125469663833370665/1176874654015684739/1258418548074745958

How to test the changes?

I played Zoroark and override the enemy pokemon with Zoroark so we can see him using correct illusion
I used illusion on a fusion and with a fusion
I tried to switch with the illusion
We can also run npm run test illusion

Old conversations here :
#2217

Checklist

• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[xsn34kzx]

Mostly NITs and minor adjustments. Brought up the idea of making illusion a property of summonData rather than to Pokemon directly, may be something to look into but ultimately not a deal breaker.

[torranx]

Please add spaces before and after the video links so it embeds correctly, and add label on what the video shows.

[torranx]

I still don't like how it's adding useIllusion- a very specific parameter just for illusion to a lot of functions

[innerthunder]

Overall I feel like the scope of Illusion-specific data should be a bit more restricted, and Illusion-specific parameters should be more generalized. My main concerns are:

• It doesn't really make sense to have illusion as a field in Pokemon when it's explicitly an in-battle effect. Usually these kinds of effects are handled within the Pokemon's summonData, battleData, battleSummonData, or turnData depending on the effect's functionality.
• The useIllusion parameter that's now fed to a lot of methods in Pokemon needs to change to account for future implementations that may want a similar effect (e.g. the enemy AI adjusting for form changes when evaluating type matchups). It would probably be more beneficial to adjust it to the inverse (say, useBaseType) where, if true, all effects that may change the Pokemon's observed type are ignored.

[flx-sta]

@PyGaVS are you still working on this?

[PyGaVS]

Okay i forgot that Zoroark can update his illusion if it's available after a switchout so i need to update that.
Otherwise i can't use BattleData or SummonData because i need to store a data (if the illusion is available or not) after a switchout if you know a way to use Illusion in SummonData or BattleData tell me on discord (with a ping).

[torranx]

The useIllusion parameter that's now fed to a lot of methods in Pokemon needs to change to account for future implementations that may want a similar effect (e.g. the enemy AI adjusting for form changes when evaluating type matchups). It would probably be more beneficial to adjust it to the inverse (say, useBaseType) where, if true, all effects that may change the Pokemon's observed type are ignored.

Did you consider updating your PR with this suggestion? Or have you got any idea on an alternative that would eliminate the use of the specific useIllusion param?