[Ability] Implement ability illusion #2217

PyGaVS · 2024-06-14T19:22:16Z

What are the changes?

Adding illusion

Why am I doing these changes?

Make ability illusion works so we can play Zoroark and make fusion with illusion

What did change?

Added PreSummonAbAttr class as ability attribute.
A pokemon with illusion create an illusion from the last pokemon of the trainer's party.
If we encounter a wild Zoroark he will use the illusion of Entei, Suicune or Raiku like in the original game. We can change that in the method generateIllusion() in src/field/pokemon.ts.
The class pokemon has a new attribute illusion.
A shiny Zoroark will create a shiny illusion.
A non shiny Zoroark will create a non-shiny illusion.
This doesn't affect the luck of course, it's just visual.
A pokemon with illusion can use illusion one time per battle like in the original game.
After a battle, the pokemon can use illusion again.
The AI move choice will be affected by the illusion.

Screenshots/Videos

https://discord.com/channels/1125469663833370665/1176874654015684739/1251234015760089159
https://discord.com/channels/1125469663833370665/1176874654015684739/1251234045204103238
https://discord.com/channels/1125469663833370665/1176874654015684739/1251234047104127039

How to test the changes?

I played Zoroark and override the enemy pokemon with Zoroark so we can see him using illusion of Raikou Suicune Entei
I used illusion on a fusion and with a fusion
I tried to switch with the illusion

Checklist

There is no overlap with another PR?
The PR is self-contained and cannot be split into smaller PRs?
Have I provided a clear explanation of the changes?
Have I tested the changes (manually)?
- Are all unit tests still passing? (npm run test)
Are the changes visual?
- Have I provided screenshots/videos of the changes?

src/data/ability.ts

src/field/pokemon.ts

DayKev · 2024-06-15T12:15:08Z

Loading the starter selection screen, backing out, and then reentering it will cause a crash. I did have a save file in slot 1 with Zorua and another pokemon from earlier testing, in case that is required to recreate the crash (though I suspect it isn't relevant).

TypeError: Cannot read properties of undefined (reading 'speciesId')
    at GameData.getSpeciesDefaultDexAttr (game-data.ts:1553:43)
    at StarterSelectUiHandler.setCursor (starter-select-ui-handler.ts:1725:50)
    at StarterSelectUiHandler.setGenMode (starter-select-ui-handler.ts:1767:12)
    at StarterSelectUiHandler.show (starter-select-ui-handler.ts:790:12)
    at doSetMode (ui.ts:450:29)
    at TimerEvent2.callback (ui.ts:459:13)
    at Clock2.update (phaser.js?v=e3bbe718:131238:42)
    at EventEmitter2.emit (phaser.js?v=e3bbe718:134:43)
    at Systems2.step (phaser.js?v=e3bbe718:111665:28)
    at SceneManager2.update (phaser.js?v=e3bbe718:109823:29)

DayKev · 2024-06-15T12:57:23Z

cf https://bulbapedia.bulbagarden.net/wiki/Illusion_(Ability)

A (mostly?) exhaustive list of things that could be tested, from the Bulbapedia page.

feat: Add link to Discord in menu UI feat: Add Discord and Google login functionality Add container around discord and google icons refactor: Update environment variable names for Discord and Google client IDs feat: Add "Or use" translation for login options in multiple languages feat: Update menu UI translations for multiple languages Code review fixes refactor: Update Discord and Google client IDs in environment variables

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

this also reduces output noise in tests

PyGaVS · 2024-07-03T01:20:59Z

I've done a lot of updates for the illusion :

-Illusion uses the appearance of the last conscious Pokémon in the party (ignoring itself), including :
Species, Form, Shininess, Pokeball, Gender
-The type will always be displayed as the Pokémon it is disguised as, even when affected by Soak etc
-The illusion will disappear if the Pokemon has its ability changed
-Pokemon cannot transform into a Pokémon that is disguised by Illusion
-Pokémon that are disguised by Illusion cannot Transform
-Wild Zoroark will be disguised as other wild Pokémon from the area. Depending on Zorua or Zoroark level the illusion will be evolved or not.
-Illusion will not activate if the last conscious Pokémon is a Terastallized Ogerpon or Terapagos.

https://discord.com/channels/1125469663833370665/1176874654015684739/1257835032647831682
https://discord.com/channels/1125469663833370665/1176874654015684739/1257864381937619045
https://discord.com/channels/1125469663833370665/1176874654015684739/1257865512801538059

I've done a lot of test to see most of the possibility with illusion. And illusion is working well for me. If you find any bug, please tell me how we can create the bug so i can correct the bug for the futur merge.

DayKev · 2024-07-03T14:00:33Z

PyGaVS · 2024-07-04T13:53:05Z

Now the pokemon can't do Illusion under neutralizing gas :
https://discord.com/channels/1125469663833370665/1176874654015684739/1258418548074745958

Fixed the broken sprites in the item atlas, and fixed the Baton Pass achievement to use the Baton item now (it was broken by the Leek being renamed). Also resized the Baton item image to 32*32, like all the other items.

…s header The removeCookie function was updated to use the Max-Age=-1 attribute instead of setting the Expires header to a past date. This change ensures that the cookie is immediately expired when removed, preventing any potential login loops. Additionally, a legacy cookie without a domain was added to handle older cookies. This commit resolves the unnecessary cookie setting in the removeCookie function.

…from party (pagefaultgames#1983) * Initial commits with logic to remove starters if they're in your party. Still need to make it work so that the starter selection cursor disappears when a starter is unselected * Updated code to be able to remove pokemon, including the side icons and cursor locations * Fixed popstarter to work with any index * Updating code to allow navigation of starter icons * Updating code to allow navigation of party starter icons * Updaing navigation of party icons * Updated logic to fix incorrect icon in top left of pokemon options when navigating the starter icons * Updated logic to include the ability to navigate and interact with the starter icons * Forgot to push the actual starter-select-ui-handler. Might be a bit hard to test things out without that :) * Removed some unnecessary comments * Fixed small bug with not being able to move from the far right to the gen selection when the starter icons were empty * Updated code to not be using a method to generate the party menu and made it more like it used to be. This should help with merge conflicts in the future * I committed the merged version but forgot to make the starter-select-ui-handler staged after making the changes * Accidentally broke challenges that had a specific typing requirement with last commit. This should fix it * Changed how navigation worked based on popular demand * Fixed code review comments * Accidentally left in a whole block of commented code. Intentionally removing it now * Started adding logic for mono type challenge runs to not break the game if the user tries to start a run with an invalid party * Updated the text to say the party is invalid * Updated logic to make invalid pokemon greyed out when no valid pokemon are in your party * Added comments on some code * Updated locales to include the key for trying to start with invalid parties during a challenge * Fixed some code from a bad merge where a challenge related param that was previously a number now needed to be a boolean and wasn't * Removed comment as per review

* Prevent Pokemon with their second ability from evolving into their HA * Add check for fusions too

* Localization(pt): Updated move.ts and fixed King's Shield * more fixes

…e when triggered (pagefaultgames#3077)

* [Sprite] Mega Latis using opposite eyes Taken from counterpart Lati * [Sprite] Update Mega Latios eyes * [Sprite] Update Mega Latias eyes * [Sprite] Mega Latias duplicated palette value Colour taken from non-exp Mega Latias

…gnet Rise (pagefaultgames#3100) * Fix Thousand Arrows not hitting through Magnet Rise * Add integration test for Thousand Arrows vs. Magnet Rise * ESLint * Remove unnecessary checks in integration tests

* Hardcoded Pokemon should have proper names * Aeroblast is a wind move

…ngle override (pagefaultgames#3104) `SINGLE_BATTLE_OVERRIDE` and `DOUBLE_BATTLE_OVERRIDE` are now `BATTLE_TYPE` Also updates all uses of the old overrides with the new one

* More TM fixes * Leaf Storm * Removed sexy matcha

flx-sta · 2024-07-31T17:51:44Z

package-lock.json

why did it touch the package-lock.json? this shouldn't happen

there is no changes inside

flx-sta · 2024-07-31T17:51:58Z

public/images/items.json

How is this noise produced?

flx-sta · 2024-07-31T17:52:15Z

src/data/ability.ts

@@ -1885,7 +1885,6 @@ export class PostSummonRemoveArenaTagAbAttr extends PostSummonAbAttr {
    return true;
  }
 }
-


NIT: why remove this new line?

not intentional

flx-sta · 2024-07-31T17:53:19Z

src/data/ability.ts

+   */
+  applyPreSummon(pokemon: Pokemon, passive: boolean, args: any[]): boolean {
+    let suppressed = false;
+    pokemon.scene.getField(true).filter(p => p !== pokemon).map(p => {


does p => p !== pokemon work in this case? I guess because they are references it does, right?

flx-sta · 2024-07-31T17:55:27Z

src/data/ability.ts

+  applyPostDefend(pokemon: Pokemon, passive: boolean, attacker: Pokemon, move: Move, hitResult: HitResult, args: any[]): boolean {
+
+    //[HitResult.EFFECTIVE, HitResult.SUPER_EFFECTIVE, HitResult.NOT_VERY_EFFECTIVE, HitResult.ONE_HIT_KO]
+    if (hitResult > 4) {


You ignored @Tempo-anon s improvement request here

PyGaVS added 5 commits June 11, 2024 00:27

get name for illusion

77d5baa

Illusion working but without AI

dc2bf95

illusion working entirely

068c935

merge up-to-date

7ed5395

add illusion

56de1e2

PyGaVS changed the title ~~Implement ability illusion~~ [Ability] Implement ability illusion Jun 14, 2024

Tempo-anon added the Ability Affects an ability label Jun 14, 2024

add comments in AbAttr classes

8927758

Tempo-anon reviewed Jun 14, 2024

View reviewed changes

PyGaVS added 2 commits June 15, 2024 00:07

add comments for the property pokemon.illusion

f79174e

update generateIllusion method

88ecabe

f-fsantos and others added 9 commits June 19, 2024 17:31

refactor: Add missing properties to initLoggedInUser function

dbb1fc1

Update src/locales/de/menu-ui-handler.ts

ef5847d

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

shiny illusion working

0dff7b4

Zoroark uses the actual form of the target as illusion

045b754

make i18n debugging an optional env setting

782718c

this also reduces output noise in tests

set development default also to "0"

e929538

illusion update

1094d55

merge up to date

7947d27

PyGaVS added 2 commits July 4, 2024 15:48

Illusion not available under neutralizing gas

973098f

Merge branch 'main' into updates

b21922b

PyGaVS added 3 commits July 5, 2024 12:59

resolve party ui handler conflict

e6d078b

resolve party ui conflicts

d197186

remove overrides changes

34e5ba4

Madmadness65 and others added 18 commits July 22, 2024 13:55

Re-add changes accidentally deleted by pagefaultgames#2617

aba7132

Fix some broken images in item atlas & achievement

04819b8

Fixed the broken sprites in the item atlas, and fixed the Baton Pass achievement to use the Baton item now (it was broken by the Leek being renamed). Also resized the Baton item image to 32*32, like all the other items.

merge up-to-date + implement illusion on nickname

348a449

update illusion test

200fa5b

fix: Remove unnecessary cookie setting in removeCookie function

b42fa55

[Bug] Ability changing on evolution fix (pagefaultgames#2995)

86ebd0c

* Prevent Pokemon with their second ability from evolving into their HA * Add check for fusions too

Localization(pt): Updated move.ts (pagefaultgames#3078)

d3c9392

* Localization(pt): Updated move.ts and fixed King's Shield * more fixes

[Bug] Enemy pokemon's Harvest creates berry icons on the player's sid…

e846498

…e when triggered (pagefaultgames#3077)

[Bug] Fix hustle not applying attack boost (pagefaultgames#3101)

799458c

[Bug] Fix Thousand Arrows not hitting targets under the effects of Ma…

1d39f8d

…gnet Rise (pagefaultgames#3100) * Fix Thousand Arrows not hitting through Magnet Rise * Add integration test for Thousand Arrows vs. Magnet Rise * ESLint * Remove unnecessary checks in integration tests

[Move] Aeroblast is a wind move (pagefaultgames#3109)

11c5c0a

* Hardcoded Pokemon should have proper names * Aeroblast is a wind move

[Refactor] Replaces the single and double battles overrides with a si…

a0502fb

…ngle override (pagefaultgames#3104) `SINGLE_BATTLE_OVERRIDE` and `DOUBLE_BATTLE_OVERRIDE` are now `BATTLE_TYPE` Also updates all uses of the old overrides with the new one

fix Overrides capitalization (pagefaultgames#3111)

5cb1125

[Balance] More TM fixes (pagefaultgames#3081)

4a04ef5

* More TM fixes * Leaf Storm * Removed sexy matcha

merge up-to-date

adf5d63

f-fsantos force-pushed the beta branch from 4bfa0e6 to 8a883ea Compare July 28, 2024 16:32

PyGaVS added 7 commits July 31, 2024 18:46

merge up-to-date

5764211

resolve unexpected merge conflicts

280f4e0

remove unexpected changes

8d54ab4

remove unexpected changes

955ceb8

remove unexpected changes

4acf2b8

Merge branch 'beta' into updates

8b46fc4

update unexpected changes

c78d9f0

flx-sta reviewed Jul 31, 2024

View reviewed changes

PyGaVS closed this Jul 31, 2024

This was referenced Jul 31, 2024

[Ability] Implement Ability Illusion #3272

Closed

[Ability] Implement Illusion #3273

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ability] Implement ability illusion #2217

[Ability] Implement ability illusion #2217

PyGaVS commented Jun 14, 2024 •

edited

Loading

DayKev commented Jun 15, 2024 •

edited

Loading

DayKev commented Jun 15, 2024 •

edited

Loading

PyGaVS commented Jul 3, 2024 •

edited

Loading

DayKev commented Jul 3, 2024

PyGaVS commented Jul 4, 2024

flx-sta Jul 31, 2024

PyGaVS Jul 31, 2024

flx-sta Jul 31, 2024

flx-sta Jul 31, 2024

PyGaVS Jul 31, 2024

flx-sta Jul 31, 2024

flx-sta Jul 31, 2024

[Ability] Implement ability illusion #2217

[Ability] Implement ability illusion #2217

Conversation

PyGaVS commented Jun 14, 2024 • edited Loading

What are the changes?

Why am I doing these changes?

What did change?

Screenshots/Videos

How to test the changes?

Checklist

DayKev commented Jun 15, 2024 • edited Loading

DayKev commented Jun 15, 2024 • edited Loading

PyGaVS commented Jul 3, 2024 • edited Loading

DayKev commented Jul 3, 2024

PyGaVS commented Jul 4, 2024

flx-sta Jul 31, 2024

Choose a reason for hiding this comment

PyGaVS Jul 31, 2024

Choose a reason for hiding this comment

flx-sta Jul 31, 2024

Choose a reason for hiding this comment

flx-sta Jul 31, 2024

Choose a reason for hiding this comment

PyGaVS Jul 31, 2024

Choose a reason for hiding this comment

flx-sta Jul 31, 2024

Choose a reason for hiding this comment

flx-sta Jul 31, 2024

Choose a reason for hiding this comment

PyGaVS commented Jun 14, 2024 •

edited

Loading

DayKev commented Jun 15, 2024 •

edited

Loading

DayKev commented Jun 15, 2024 •

edited

Loading

PyGaVS commented Jul 3, 2024 •

edited

Loading