-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ability] Partially implement Gulp Missile #3327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving this to draft because I mistakenly removed the test involving Magic Guard. Will possibly update Dive and Surf score calculation too. |
Tempo-anon
reviewed
Aug 5, 2024
innerthunder
reviewed
Aug 5, 2024
Tempo-anon
reviewed
Aug 6, 2024
torranx
changed the title
[Ability] Fully implement Gulp Missile
[Ability] Partially implement Gulp Missile
Aug 6, 2024
9 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
partially implements gulp missile:
Does not transform when Surf/Dive misses/is protected
Why am I doing these changes?
unimplemented ability
What did change?
PostDefendGulpMissileAbAttr
GulpMissileTag
GulpMissileTagAttr
Screenshots/Videos
Screen.Recording.2024-08-05.at.5.15.28.AM.mov
Screen.Recording.2024-08-05.at.5.17.51.AM.mov
How to test the changes?
overrides used:
$ npm run test gulp_missile
Checklist
beta
as my base branchnpm run test
)