Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ability] Partially implement Gulp Missile #3327

Merged
merged 11 commits into from
Aug 6, 2024

Conversation

torranx
Copy link
Collaborator

@torranx torranx commented Aug 4, 2024

What are the changes?

partially implements gulp missile:
Does not transform when Surf/Dive misses/is protected

Why am I doing these changes?

unimplemented ability

What did change?

  • added new abattr class PostDefendGulpMissileAbAttr
  • added new battlertag GulpMissileTag
  • added new move attr GulpMissileTagAttr

Screenshots/Videos

  • Gulping form
Screen.Recording.2024-08-05.at.5.15.28.AM.mov
  • Gorging form
Screen.Recording.2024-08-05.at.5.17.51.AM.mov

How to test the changes?

overrides used:

{
  BATTLE_TYPE_OVERRIDE: "single",
  STARTER_SPECIES_OVERRIDE: Species.CRAMORANT,
  ABILITY_OVERRIDE: Abilities.GULP_MISSILE,
  MOVESET_OVERRIDE: [Moves.DIVE, Moves.SURF, Moves.SPLASH, Moves.QUICK_ATTACK],
  OPP_LEVEL_OVERRIDE: 5,
  OPP_MOVESET_OVERRIDE: Array(4).fill(Moves.TACKLE)
}

$ npm run test gulp_missile

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Madmadness65 Madmadness65 added the Ability Affects an ability label Aug 4, 2024
@torranx torranx marked this pull request as ready for review August 4, 2024 21:20
@torranx
Copy link
Collaborator Author

torranx commented Aug 4, 2024

Moving this to draft because I mistakenly removed the test involving Magic Guard. Will possibly update Dive and Surf score calculation too.

@torranx torranx marked this pull request as draft August 4, 2024 21:50
@torranx torranx marked this pull request as ready for review August 4, 2024 22:04
src/data/ability.ts Outdated Show resolved Hide resolved
src/data/battler-tags.ts Outdated Show resolved Hide resolved
src/data/battler-tags.ts Outdated Show resolved Hide resolved
src/data/move.ts Outdated Show resolved Hide resolved
@torranx torranx requested a review from Tempo-anon August 5, 2024 06:01
@torranx torranx marked this pull request as draft August 5, 2024 20:03
@torranx torranx changed the title [Ability] Fully implement Gulp Missile [Ability] Partially implement Gulp Missile Aug 6, 2024
@torranx torranx marked this pull request as ready for review August 6, 2024 20:13
@Tempo-anon Tempo-anon merged commit 9875fcc into pagefaultgames:beta Aug 6, 2024
4 checks passed
@torranx torranx mentioned this pull request Aug 9, 2024
@torranx torranx deleted the ability-gulp_missle branch October 4, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants