Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Fully Implement Gulp Missile #3438

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes?

This change fully implements Gulp Missile by fixing an interaction with Dive (Cramorant now changes form during Dive's first turn).

Why am I doing these changes?

Gulp Missile was partially implemented in #3327. This finishes the implementation.

What did change?

  • data/move: Dive's ChargeAttr now uses the chargeEffect parameter to trigger Gulp Missile's form change on the move's first turn of use.
  • data/ability:
    • Added a check for SemiInvulnerableTag so Gulp Missile no longer activates while Cramorant is underwater.
    • Removed .partial() from Gulp Missile's attributes.
  • form-change-phase: Added a check for SemiInvulnerableTag so quiet form changes don't play animations while the target Pokemon is hidden from view
  • test/abilities/gulp_missile.test: Added a test to check that Cramorant changes form on the first turn of using Dive.

Screenshots/Videos

Video of Cramorant changing forms when using Dive:

PokeRogueTest-GulpMissileDive.mp4

How to test the changes?

npm run test gulp_missile

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

src/data/ability.ts Show resolved Hide resolved
src/form-change-phase.ts Show resolved Hide resolved
@Tempo-anon Tempo-anon merged commit 7f5e873 into pagefaultgames:beta Aug 8, 2024
4 checks passed
@innerthunder innerthunder deleted the gulp-missile branch October 11, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants