[Move] Fully Implement Gulp Missile #3438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
This change fully implements Gulp Missile by fixing an interaction with Dive (Cramorant now changes form during Dive's first turn).
Why am I doing these changes?
Gulp Missile was partially implemented in #3327. This finishes the implementation.
What did change?
data/move
: Dive'sChargeAttr
now uses thechargeEffect
parameter to trigger Gulp Missile's form change on the move's first turn of use.data/ability
:SemiInvulnerableTag
so Gulp Missile no longer activates while Cramorant is underwater..partial()
from Gulp Missile's attributes.form-change-phase
: Added a check forSemiInvulnerableTag
so quiet form changes don't play animations while the target Pokemon is hidden from viewtest/abilities/gulp_missile.test
: Added a test to check that Cramorant changes form on the first turn of using Dive.Screenshots/Videos
Video of Cramorant changing forms when using Dive:
PokeRogueTest-GulpMissileDive.mp4
How to test the changes?
npm run test gulp_missile
Checklist
beta
as my base branchnpm run test
)