Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Add Japanese Localization #3332

Merged
merged 25 commits into from
Aug 7, 2024
Merged

Conversation

Tempo-anon
Copy link
Collaborator

@Tempo-anon Tempo-anon commented Aug 4, 2024

What are the changes?

Mirror of #2771

Why am I doing these changes?

Add Japanese Localization

What did change?

  • Added Galmuri11.subset.wolff2 Galmuri9.subset.woff2, PokePT_Wansung.woff2, unifont-15.1.05.subset.woff2
  • Added ja type icons
  • Added Japanese localization

Screenshots/Videos

How to test the changes?

Pull and change language

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added the Localization Provides or updates translation efforts label Aug 4, 2024
@EnochG1
Copy link
Contributor

EnochG1 commented Aug 4, 2024

Can you separate font between Chinese and Japanese?
Maybe Japanese font is applied to Chinese, too.
image

Original Chinese font (beta branch)
image

In your ja branch.
Fonts are mixing because some Letter exists both Japanese and Chinese, some not.
image

@EnochG1
Copy link
Contributor

EnochG1 commented Aug 4, 2024

Also, Japanese font sizes are inconsistent.
(For example in settings, I thought only the text in the selected setting was large, but it's not consistent.)
image

@EnochG1
Copy link
Contributor

EnochG1 commented Aug 4, 2024

I added missed things https://github.com/Tempo-anon/pokerogue/pull/10/files

[Localization][JA] Add missed message keys
src/plugins/i18n.ts Outdated Show resolved Hide resolved
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Copy link
Contributor

@EnochG1 EnochG1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix this BIG FONT in other language.

image

src/plugins/i18n.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@EnochG1 EnochG1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I found something

image

src/ui/text.ts Outdated Show resolved Hide resolved
Tempo-anon and others added 2 commits August 4, 2024 20:40
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
@Tempo-anon Tempo-anon marked this pull request as ready for review August 5, 2024 00:58
Copy link
Collaborator

@xsn34kzx xsn34kzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filled in entries for items I've been responsible for with Scarlet/Violet's ripped text (from https://abcboy101.github.io/poke-corpus, more direct links attached for each suggestion). Definitely want another set of eyes on these for obvious reasons, but this should be good to start with.

src/locales/ja/modifier-type.ts Outdated Show resolved Hide resolved
src/locales/ja/modifier-type.ts Outdated Show resolved Hide resolved
src/locales/ja/modifier-type.ts Outdated Show resolved Hide resolved
@EnochG1 EnochG1 mentioned this pull request Aug 5, 2024
7 tasks
@EnochG1
Copy link
Contributor

EnochG1 commented Aug 5, 2024

I submitted PR for translating move, ability.
Tempo-anon#11

@Chapybara-jp
Copy link
Contributor

Chapybara-jp commented Aug 5, 2024

Hi! I PR'd several changes to #1861 which Chepyu accepted after it was first mirrored. It seems @Chepyu had not actually stopped working on that branch, so I'm not sure why it was closed. Either way, I can PR the changes I made to this branch as well.

@EnochG1
Copy link
Contributor

EnochG1 commented Aug 5, 2024

Hi! I PR'd several changes to #1861 which Chepyu accepted after it was first mirrored. It seems @Chepyu had not actually stopped working on that branch, so I'm not sure why it was closed. Either way, I can PR the changes I made to this branch as well.

@Chapybara-jp Hi,
Most branches(PR) were broken after 2nd 'beta' branch was created. (Also merge policy was changed after #1861) And we are trying to revive Japanese Localization.
It would be sooo good if you and @Chepyu(or others) give some help to Translate.
FYI, please feel free to join Discord :) either main(including dev channel) or Wiki(including i game translation channel).

@Chapybara-jp
Copy link
Contributor

Hi! I PR'd several changes to #1861 which Chepyu accepted after it was first mirrored. It seems @Chepyu had not actually stopped working on that branch, so I'm not sure why it was closed. Either way, I can PR the changes I made to this branch as well.

@Chapybara-jp Hi, Most branches(PR) were broken after 2nd 'beta' branch was created. (Also merge policy was changed after #1861) And we are trying to revive Japanese Localization. It would be sooo good if you and @Chepyu(or others) give some help to Translate. FYI, please feel free to join Discord :) either main(including dev channel) or Wiki(including i game translation channel).

Ah, I see! Then I'll PR my changes to this branch later today. I'll join the discord and Wiki as well!

@EnochG1
Copy link
Contributor

EnochG1 commented Aug 5, 2024

@Chapybara-jp Perfect!
Please ping me when you join pokerogue discord. Because wiki(translation) discord is currently not public :)

Tempo-anon and others added 7 commits August 5, 2024 10:08
[Localization] Translate essential Japanese - move, ability
- All phrases are taken from USUM script via Poké Corpus https://abcboy101.github.io/poke-corpus/ 
(I used the USUM script because it is in hiragana/katakana. If we decide to change these phrases to Kanji later, I will refer to the SV script to modify them again.)
-
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
@Tempo-anon Tempo-anon merged commit 98ae2bc into pagefaultgames:beta Aug 7, 2024
4 checks passed
Copy link
Contributor

@protimita protimita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move-triggers.ts Japanese Translation.
All spaces are full-width.
regainHealth, healHP, and tookMoveAttack need in-game checking to see if they're used correctly.
acquiredAbility is improvised text, not original.

Comment on lines +4 to +61
"hitWithRecoil" : "{{pokemonName}} was damaged by the recoil!",
"cutHpPowerUpMove": "{{pokemonName}} cut its own HP to power up its move!",
"absorbedElectricity": "{{pokemonName}} absorbed electricity!",
"switchedStatChanges": "{{pokemonName}} switched stat changes with the target!",
"goingAllOutForAttack": "{{pokemonName}} is going all out for this attack!",
"regainedHealth": "{{pokemonName}} regained\nhealth!",
"keptGoingAndCrashed": "{{pokemonName}} kept going\nand crashed!",
"fled": "{{pokemonName}} fled!",
"cannotBeSwitchedOut": "{{pokemonName}} can't be switched out!",
"swappedAbilitiesWithTarget": "{{pokemonName}} swapped\nabilities with its target!",
"coinsScatteredEverywhere": "Coins were scattered everywhere!",
"attackedByItem": "{{pokemonName}} is about to be attacked by its {{itemName}}!",
"whippedUpAWhirlwind": "{{pokemonName}} whipped\nup a whirlwind!",
"flewUpHigh": "{{pokemonName}} flew\nup high!",
"tookInSunlight": "{{pokemonName}} absorbed light!",
"dugAHole": "{{pokemonName}} burrowed its way under the ground!",
"loweredItsHead": "{{pokemonName}} tucked in its head!",
"isGlowing": "{{pokemonName}} became cloaked in a harsh light!",
"bellChimed": "A bell chimed!",
"foresawAnAttack": "{{pokemonName}} foresaw\nan attack!",
"hidUnderwater": "{{pokemonName}} hid\nunderwater!",
"soothingAromaWaftedThroughArea": "A soothing aroma wafted through the area!",
"sprangUp": "{{pokemonName}} sprang up!",
"choseDoomDesireAsDestiny": "{{pokemonName}} chose\nDoom Desire as its destiny!",
"vanishedInstantly": "{{pokemonName}} vanished\ninstantly!",
"tookTargetIntoSky": "{{pokemonName}} took {{targetName}}\ninto the sky!",
"becameCloakedInFreezingLight": "{{pokemonName}} became cloaked\nin a freezing light!",
"becameCloakedInFreezingAir": "{{pokemonName}} became cloaked\nin freezing air!",
"isChargingPower": "{{pokemonName}} is absorbing power!",
"burnedItselfOut": "{{pokemonName}} burned itself out!",
"startedHeatingUpBeak": "{{pokemonName}} started\nheating up its beak!",
"isOverflowingWithSpacePower": "{{pokemonName}} is overflowing\nwith space power!",
"usedUpAllElectricity": "{{pokemonName}} used up all its electricity!",
"stoleItem": "{{pokemonName}} stole\n{{targetName}}'s {{itemName}}!",
"incineratedItem": "{{pokemonName}} incinerated\n{{targetName}}'s {{itemName}}!",
"knockedOffItem": "{{pokemonName}} knocked off\n{{targetName}}'s {{itemName}}!",
"tookMoveAttack": "{{pokemonName}} took\nthe {{moveName}} attack!",
"cutOwnHpAndMaximizedStat": "{{pokemonName}} cut its own HP\nand maximized its {{statName}}!",
"copiedStatChanges": "{{pokemonName}} copied\n{{targetName}}'s stat changes!",
"magnitudeMessage": "Magnitude {{magnitude}}!",
"tookAimAtTarget": "{{pokemonName}} took aim\nat {{targetName}}!",
"transformedIntoType": "{{pokemonName}} transformed\ninto the {{typeName}} type!",
"copiedMove": "{{pokemonName}} copied\n{{moveName}}!",
"sketchedMove": "{{pokemonName}} sketched\n{{moveName}}!",
"acquiredAbility": "The {{pokemonName}} acquired\n{{abilityName}}!",
"copiedTargetAbility": "{{pokemonName}} copied the {{targetName}}'s\n{{abilityName}}!",
"transformedIntoTarget": "{{pokemonName}} transformed\ninto {{targetName}}!",
"tryingToTakeFoeDown": "{{pokemonName}} is hoping to take its attacker down with it!",
"addType": "{{typeName}} was added to\n{{pokemonName}}!",
"cannotUseMove": "{{pokemonName}} cannot use {{moveName}}!",
"healHp": "{{pokemonName}} had its HP restored.",
"sacrificialFullRestore": "{{pokemonName}}'s Healing Wish\nwas granted!",
"invertStats": "{{pokemonName}}'s stat changes\nwere all reversed!",
"resetStats": "{{pokemonName}}'s stat changes\nwere eliminated!",
"faintCountdown": "{{pokemonName}}\nwill faint in {{turnCount}} turns.",
"copyType": "{{pokemonName}}'s type became the same as\n{{targetPokemonName}}'s type!",
"suppressAbilities": "{{pokemonName}}'s ability\nwas suppressed!",
"swapArenaTags": "{{pokemonName}} swapped the battle effects affecting each side of the field!",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"hitWithRecoil" : "{{pokemonName}} was damaged by the recoil!",
"cutHpPowerUpMove": "{{pokemonName}} cut its own HP to power up its move!",
"absorbedElectricity": "{{pokemonName}} absorbed electricity!",
"switchedStatChanges": "{{pokemonName}} switched stat changes with the target!",
"goingAllOutForAttack": "{{pokemonName}} is going all out for this attack!",
"regainedHealth": "{{pokemonName}} regained\nhealth!",
"keptGoingAndCrashed": "{{pokemonName}} kept going\nand crashed!",
"fled": "{{pokemonName}} fled!",
"cannotBeSwitchedOut": "{{pokemonName}} can't be switched out!",
"swappedAbilitiesWithTarget": "{{pokemonName}} swapped\nabilities with its target!",
"coinsScatteredEverywhere": "Coins were scattered everywhere!",
"attackedByItem": "{{pokemonName}} is about to be attacked by its {{itemName}}!",
"whippedUpAWhirlwind": "{{pokemonName}} whipped\nup a whirlwind!",
"flewUpHigh": "{{pokemonName}} flew\nup high!",
"tookInSunlight": "{{pokemonName}} absorbed light!",
"dugAHole": "{{pokemonName}} burrowed its way under the ground!",
"loweredItsHead": "{{pokemonName}} tucked in its head!",
"isGlowing": "{{pokemonName}} became cloaked in a harsh light!",
"bellChimed": "A bell chimed!",
"foresawAnAttack": "{{pokemonName}} foresaw\nan attack!",
"hidUnderwater": "{{pokemonName}} hid\nunderwater!",
"soothingAromaWaftedThroughArea": "A soothing aroma wafted through the area!",
"sprangUp": "{{pokemonName}} sprang up!",
"choseDoomDesireAsDestiny": "{{pokemonName}} chose\nDoom Desire as its destiny!",
"vanishedInstantly": "{{pokemonName}} vanished\ninstantly!",
"tookTargetIntoSky": "{{pokemonName}} took {{targetName}}\ninto the sky!",
"becameCloakedInFreezingLight": "{{pokemonName}} became cloaked\nin a freezing light!",
"becameCloakedInFreezingAir": "{{pokemonName}} became cloaked\nin freezing air!",
"isChargingPower": "{{pokemonName}} is absorbing power!",
"burnedItselfOut": "{{pokemonName}} burned itself out!",
"startedHeatingUpBeak": "{{pokemonName}} started\nheating up its beak!",
"isOverflowingWithSpacePower": "{{pokemonName}} is overflowing\nwith space power!",
"usedUpAllElectricity": "{{pokemonName}} used up all its electricity!",
"stoleItem": "{{pokemonName}} stole\n{{targetName}}'s {{itemName}}!",
"incineratedItem": "{{pokemonName}} incinerated\n{{targetName}}'s {{itemName}}!",
"knockedOffItem": "{{pokemonName}} knocked off\n{{targetName}}'s {{itemName}}!",
"tookMoveAttack": "{{pokemonName}} took\nthe {{moveName}} attack!",
"cutOwnHpAndMaximizedStat": "{{pokemonName}} cut its own HP\nand maximized its {{statName}}!",
"copiedStatChanges": "{{pokemonName}} copied\n{{targetName}}'s stat changes!",
"magnitudeMessage": "Magnitude {{magnitude}}!",
"tookAimAtTarget": "{{pokemonName}} took aim\nat {{targetName}}!",
"transformedIntoType": "{{pokemonName}} transformed\ninto the {{typeName}} type!",
"copiedMove": "{{pokemonName}} copied\n{{moveName}}!",
"sketchedMove": "{{pokemonName}} sketched\n{{moveName}}!",
"acquiredAbility": "The {{pokemonName}} acquired\n{{abilityName}}!",
"copiedTargetAbility": "{{pokemonName}} copied the {{targetName}}'s\n{{abilityName}}!",
"transformedIntoTarget": "{{pokemonName}} transformed\ninto {{targetName}}!",
"tryingToTakeFoeDown": "{{pokemonName}} is hoping to take its attacker down with it!",
"addType": "{{typeName}} was added to\n{{pokemonName}}!",
"cannotUseMove": "{{pokemonName}} cannot use {{moveName}}!",
"healHp": "{{pokemonName}} had its HP restored.",
"sacrificialFullRestore": "{{pokemonName}}'s Healing Wish\nwas granted!",
"invertStats": "{{pokemonName}}'s stat changes\nwere all reversed!",
"resetStats": "{{pokemonName}}'s stat changes\nwere eliminated!",
"faintCountdown": "{{pokemonName}}\nwill faint in {{turnCount}} turns.",
"copyType": "{{pokemonName}}'s type became the same as\n{{targetPokemonName}}'s type!",
"suppressAbilities": "{{pokemonName}}'s ability\nwas suppressed!",
"swapArenaTags": "{{pokemonName}} swapped the battle effects affecting each side of the field!",
"hitWithRecoil" : "{{pokemonName}}は\nはんどうによる ダメージを うけた!",
"cutHpPowerUpMove": "{{pokemonName}}は\nたいりょくを けずって パワーぜんかい!",
"absorbedElectricity": "{{pokemonName}}は\n でんきを きゅうしゅうした!",
"switchedStatChanges": "{{pokemonName}}は あいてと じぶんのn\のうりょくへんかを いれかえた!",
"goingAllOutForAttack": "{{pokemonName}}は\nほんきを だした!",
"regainedHealth": "{{pokemonName}}は\nたいりょくを かいふくした!",
"keptGoingAndCrashed": "いきおいあまって {{pokemonName}}は\nじめんに ぶつかった!",
"fled": "{{pokemonName}}は にげだした!",
"cannotBeSwitchedOut": "{{pokemonName}}を\nもどすことが できない!",
"swappedAbilitiesWithTarget": "{{pokemonName}}は\nおたがいの とくせいを いれかえた!",
"coinsScatteredEverywhere": "こばんが あたりに ちらばった!",
"attackedByItem": "{{pokemonName}}に\n{{itemName}}が おそいかかる!",
"whippedUpAWhirlwind": "{{pokemonName}}の まわりで\nくうきが うずをまく!",
"flewUpHigh": "{{pokemonName}}は\nそらたかく とびあがった!",
"tookInSunlight": "{{pokemonName}}は\nひかりを きゅうしゅうした!",
"dugAHole": "{{pokemonName}}は\nじめんに もぐった!",
"loweredItsHead": "{{pokemonName}}は\nくびを ひっこめた!",
"isGlowing": "{{pokemonName}}を\nはげしいひかりが つつむ!",
"bellChimed": "すずのおとが ひびきわたった!",
"foresawAnAttack": "{{pokemonName}}は\nみらいに こうげきを よちした!",
"hidUnderwater": "{{pokemonName}}は\nすいちゅうに みをひそめた!",
"soothingAromaWaftedThroughArea": "ここちよい かおりが ひろがった!",
"sprangUp": "{{pokemonName}}は\nたかく とびはねた!",
"choseDoomDesireAsDestiny": "{{pokemonName}}は\nはめつのねがいを みらいに たくした!",
"vanishedInstantly": "{{pokemonName}}の すがたが\nいっしゅんにして きえた!",
"tookTargetIntoSky": "{{pokemonName}}{{targetName}}を\nじょうくうに つれさった!",
"becameCloakedInFreezingLight": "{{pokemonName}}は\nつめたいひかりに つつまれた!",
"becameCloakedInFreezingAir": "{{pokemonName}}は\nこごえるくうきに つつまれた!",
"isChargingPower": "{{pokemonName}}は\nパワーを ためこんでいる!",
"burnedItselfOut": "{{pokemonName}}の ほのうは\nもえつきた!",
"startedHeatingUpBeak": "{{pokemonName}}は\nクチバシを かねつしはじめた!",
"isOverflowingWithSpacePower": "{{pokemonName}}に\nうちゅうの ちからが あふれだす!",
"usedUpAllElectricity": "{{pokemonName}}は\nでんきを つかいきった!",
"stoleItem": "{{pokemonName}}\n{{targetName}} {{itemName}}を ぬすんだ!",
"incineratedItem": "{{pokemonName}}\n{{targetName}} {{itemName}}を もやした!",
"knockedOffItem": "{{pokemonName}}\n{{targetName}} {{itemName}}を はたきおとした!",
"tookMoveAttack": "{{pokemonName}}は\n{{moveName}}の こうげきを うけた!",
"cutOwnHpAndMaximizedStat": "{{pokemonName}}は\nたいりょくを けずって {{statName}}ぜんかい!",
"copiedStatChanges": "{{pokemonName}}は {{targetName}}の\nのうりょくへんかを コピーした!",
"magnitudeMessage": "マグニチュード{{magnitude}}",
"tookAimAtTarget": "{{pokemonName}}{{targetName}}に\nねらいを さだめた!",
"transformedIntoType": "{{pokemonName}}は\n{{typeName}}タイプに なった!",
"copiedMove": "{{pokemonName}}\n{{moveName}}を コピーした!",
"sketchedMove": "{{pokemonName}}\n{{moveName}}を スケッチした!",
"acquiredAbility": "{{pokemonName}}の とくせいが\n{{abilityName}}に なった!",
"copiedTargetAbility": "{{pokemonName}}は\n{{targetName}}の {{abilityName}}を コピーした!",
"transformedIntoTarget": "{{pokemonName}}は\n{{targetName}}に へんしんした!",
"tryingToTakeFoeDown": "{{pokemonName}}は あいてを\nみちづれに しようとしている!",
"addType": "{{pokemonName}}に\n{{typeName}}タイプが ついかされた!",
"cannotUseMove": "{{pokemonName}}は\n{{moveName}}を つかえなかった!",
"healHp": "{{pokemonName}}の\nたいりょくが かいふくした!",
"sacrificialFullRestore": "{{pokemonName}}の\nねがいごとが かなった!",
"invertStats": "{{pokemonName}}の\nのうりょくへんかが ぎゃくてんした!",
"resetStats": "{{pokemonName}}の\nのうりょくへんかが もとにもどった!",
"faintCountdown": "{{pokemonName}}は\n{{turnCount}}ターンごに ほろびてしまう!",
"copyType": "{{pokemonName}}は {{targetPokemonName}}と\n同じタイプに なった!",
"suppressAbilities": "{{pokemonName}}の とくせいが きかなくなった!",
"swapArenaTags": "{{pokemonName}}は\nおたがいの ばのこうかを いれかえた!",

@EnochG1
Copy link
Contributor

EnochG1 commented Aug 7, 2024

@protimita Due this PR is already merged so I would create new one and apply your suggestion. Please wait 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants