Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Beta] Fix "Critical Hit" message appearing before dealing damage #4259

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

The message "A critical hit!" now correctly appears after damage is dealt.

Why am I making these changes?

fixes #4251

What are the changes from a developer perspective?

field/pokemon: The critical hit message generated in Pokemon#apply now occurs after the call to Pokemon.damageAndUpdate instead of before.

Screenshots/Videos

PokeRogue.-.Google.Chrome.2024-09-14.11-04-56.mp4

How to test the changes?

  1. Give your Pokemon Flower Trick with MOVESET_OVERRIDE in src/overrides.ts
  2. Use Flower Trick
  3. The critical hit message should happen after damage animations

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@innerthunder innerthunder requested a review from a team as a code owner September 14, 2024 18:14
@innerthunder innerthunder added P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. Move Affects a move labels Sep 14, 2024
@innerthunder innerthunder linked an issue Sep 14, 2024 that may be closed by this pull request
@Tempo-anon Tempo-anon merged commit 79fa80c into pagefaultgames:beta Sep 14, 2024
14 checks passed
@innerthunder innerthunder deleted the crit-message-fix branch October 11, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] damage animation delay for critical hits
2 participants