[#IOCOM-166] Fixed destroy handler with a NOOP #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldisaro
requested review from
AleDore,
BurnedMarshal and
balanza
as code owners
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOCOM-166 |
balanza
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node18 introduced a new destroy handler that seems to not be needed for our functions but was causing some functions to crash because of our custom IncomingMessage.
This fix binds a NOOP function to the destroy method of our IncomingMessage, as we did years ago with the socket.