Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOCOM-166] Fixed destroy handler with a NOOP #37

Merged
merged 2 commits into from
Apr 17, 2023
Merged

[#IOCOM-166] Fixed destroy handler with a NOOP #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7baac25
fixed destroy handler with a NOOP
michaeldisaro Apr 17, 2023
a842cfe
fixed linter
michaeldisaro Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/IncomingMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ export default class IncomingMessage extends Readable {
...req, // Inherit
connection: createConnectionObject(context),
context: sanitizeContext(context), // Specific to Azure Function
destroy: NOOP, // we are not interested in new destroy implementation
headers: req.headers || {}, // Should always have a headers object
socket: { destroy: NOOP },
socket: { destroy: NOOP }, // we should not destroy the socket
// eslint-disable-next-line @typescript-eslint/no-explicit-any
url: (req as any).originalUrl
});
Expand Down