Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1450] Enable strict mode on repo #231

Merged
merged 12 commits into from
Mar 19, 2024
Merged

[#IOPID-1450] Enable strict mode on repo #231

merged 12 commits into from
Mar 19, 2024

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented Mar 5, 2024 •
edited
Loading

List of Changes

Motivation and Context

Enable strict mode on this repo by incrementally enabling the following flags (see here):

  • noImplicitAny
  • strictNullChecks
  • noImplicitThis
  • strictFunctionTypes
  • strictPropertyInitialization
  • strictBindCallApply
  • alwaysStrict
  • useUnknownInCatchVariables

Since Strict mode is actually a combination of this six other flags.

How Has This Been Tested?

Unit tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1450

@gquadrati gquadrati marked this pull request as ready for review March 12, 2024 11:38
@gquadrati gquadrati requested a review from a team as a code owner March 12, 2024 11:38
@gquadrati gquadrati requested review from grausof, giamma1295, BurnedMarshal and arcogabbo and removed request for a team March 12, 2024 11:38
@gquadrati @rodoviti
Update DeleteUserDataActivity/utils.ts
f61309a 
Co-authored-by: Rodolfo Viti <62432865+rodoviti@users.noreply.github.com>
rodoviti
rodoviti approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@rodoviti rodoviti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (for "services pov")

BurnedMarshal
BurnedMarshal requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1

DeleteUserDataActivity/__tests__/backupAndDelete.test.ts Outdated Show resolved Hide resolved
DeleteUserDataActivity/backupAndDelete.ts Outdated Show resolved Hide resolved
GetFailedUserDataProcessing/handler.ts Show resolved Hide resolved
GetServices/handler.ts Outdated Show resolved Hide resolved
@gquadrati gquadrati requested a review from BurnedMarshal March 14, 2024 08:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@gquadrati gquadrati merged commit 0337e96 into master Mar 19, 2024
3 of 4 checks passed
@gquadrati gquadrati deleted the IOPID-1450 branch March 19, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodoviti rodoviti rodoviti approved these changes

@arcogabbo arcogabbo arcogabbo approved these changes

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@grausof grausof Awaiting requested review from grausof grausof is a code owner automatically assigned from pagopa/io-backend-contributors

@giamma1295 giamma1295 Awaiting requested review from giamma1295 giamma1295 is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gquadrati @BurnedMarshal @arcogabbo @rodoviti