[#IOPID-1450] Enable strict mode on repo

CreateDevelopmentProfile/handler.ts

@@ -49,9 +49,10 @@ export function toExtendedProfile(profile: RetrievedProfile): ExtendedProfile {
     accepted_tos_version: profile.acceptedTosVersion,
     blocked_inbox_or_channels: profile.blockedInboxOrChannels,
     email: profile.email,
-    is_email_already_taken: undefined,
-    is_email_enabled: profile.isEmailEnabled,
-    is_email_validated: profile.isEmailValidated,
+    // NOTE: We do NOT check email uniqueness in this context
+    is_email_already_taken: false,
+    is_email_enabled: profile.isEmailEnabled !== false,
+    is_email_validated: profile.isEmailValidated !== false,
     is_inbox_enabled: profile.isInboxEnabled === true,
     is_webhook_enabled: profile.isWebhookEnabled === true,
     preferred_languages: profile.preferredLanguages,

CreateSubscription/__tests__/handler.test.ts

@@ -51,7 +51,7 @@ const aFakeApimProductContract: ProductContract = {
 const aFakeApimSubscriptionContract: SubscriptionContract = {
   allowTracing: false,
   createdDate: new Date(),
-  displayName: null,
+  displayName: undefined,
   endDate: undefined,
   expirationDate: undefined,
   id: "subscription-id",

CreateUser/handler.ts

@@ -120,6 +120,9 @@ export function CreateUserHandler(
               taskResults.apimClient.user.createOrUpdate(
                 azureApimConfig.apimResourceGroup,
                 azureApimConfig.apim,
+                // TODO: Implement a validation step to ensure the existence of `objectId`
+                // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+                // @ts-ignore
                 taskResults.objectId,
                 {
                   email: userPayload.email,

DeleteUserDataActivity/__tests__/backupAndDelete.test.ts

@@ -37,7 +37,7 @@ const asyncIteratorOf = <T>(items: T[]): AsyncIterator<T[]> => {
       const value = data.shift();
       return {
         done: typeof value === "undefined",
-        value: [value]
+        value: [value!]
       };
     }
   };

DeleteUserDataActivity/backupAndDelete.ts

@@ -2,12 +2,11 @@ import * as crypto from "crypto";
 
 import { BlobService } from "azure-storage";
 import { sequenceT } from "fp-ts/lib/Apply";
-import * as A from "fp-ts/lib/Array";
+import * as RA from "fp-ts/lib/ReadonlyArray";
 import * as E from "fp-ts/lib/Either";
 import * as O from "fp-ts/lib/Option";
 import * as TE from "fp-ts/lib/TaskEither";
 
-import { array, flatten, rights } from "fp-ts/lib/Array";
 import { MessageContent } from "@pagopa/io-functions-commons/dist/generated/definitions/MessageContent";
 import {
   RetrievedMessage,
@@ -40,6 +39,7 @@ import {
   QueryFailure
 } from "./types";
 import {
+  isCosmosErrors,
   saveDataToBlob,
   toDocumentDeleteFailure,
   toQueryFailure
@@ -67,18 +67,18 @@ const executeRecursiveBackupAndDelete = <T>(
     TE.mapLeft(toQueryFailure),
     TE.chainW(e =>
       e.done
-        ? TE.of([])
+        ? TE.of<DataFailure, ReadonlyArray<T>>([])
         : e.value.some(E.isLeft)
-        ? TE.left(
+        ? TE.left<DataFailure, ReadonlyArray<T>>(
             toQueryFailure(new Error("Some elements are not typed correctly"))
           )
-        : TE.of(rights(e.value))
+        : TE.of<DataFailure, ReadonlyArray<T>>(RA.rights(e.value))
     ),
     // executes backup&delete for this set of items
     TE.chainW(items =>
       pipe(
         items,
-        A.map((item: T) =>
+        RA.map((item: T) =>
           pipe(
             sequenceT(TE.ApplicativeSeq)<
               DataFailure,
@@ -104,8 +104,8 @@ const executeRecursiveBackupAndDelete = <T>(
             TE.map(([_, __, nextResults]) => [item, ...nextResults])
           )
         ),
-        A.sequence(TE.ApplicativePar),
-        TE.map(flatten)
+        RA.sequence(TE.ApplicativePar),
+        TE.map(RA.flatten)
       )
     )
   );
@@ -365,7 +365,7 @@ const backupAndDeleteMessageView = ({
 }): TE.TaskEither<DataFailure, O.Option<RetrievedMessageView>> =>
   pipe(
     messageViewModel.find([message.id, message.fiscalCode]),
-    TE.chain(TE.fromOption(() => undefined)),
+    TE.chainW(TE.fromOption(() => undefined)),
     TE.foldW(
       _ =>
         // unfortunately, a document not found is threated like a query error
@@ -443,7 +443,7 @@ const backupAndDeleteMessageContent = ({
 }): TE.TaskEither<DataFailure, O.Option<MessageContent>> =>
   pipe(
     messageModel.getContentFromBlob(messageContentBlobService, message.id),
-    TE.chain(TE.fromOption(() => undefined)),
+    TE.chainW(TE.fromOption(() => undefined)),
     TE.foldW(
       _ =>
         // unfortunately, a document not found is threated like a query error
@@ -587,19 +587,25 @@ const backupAndDeleteAllMessagesData = ({
   pipe(
     messageModel.findMessages(fiscalCode),
     TE.mapLeft(toQueryFailure),
-    TE.chain(iter =>
-      TE.tryCatch(() => asyncIteratorToArray(iter), toQueryFailure)
+    TE.chainW(iter =>
+      TE.tryCatch(
+        () => asyncIteratorToArray(iter),
+        err =>
+          err instanceof Error || isCosmosErrors(err)
+            ? toQueryFailure(err)
+            : toQueryFailure(E.toError(err))
+      )
     ),
-    TE.map(flatten),
+    TE.map(RA.flatten),
     TE.chainW(results =>
       results.some(E.isLeft)
         ? TE.left(
             toQueryFailure(
               new Error("Cannot decode some element due to decoding errors")
             )
           )
-        : array.sequence(TE.ApplicativeSeq)(
-            rights(results).map(message => {
+        : RA.sequence(TE.ApplicativeSeq)(
+            RA.rights(results).map(message => {
               // cast needed because findMessages has a wrong signature
               // eslint-disable-next-line @typescript-eslint/no-explicit-any
               const retrievedMessage = (message as any) as RetrievedMessageWithoutContent;

DeleteUserDataActivity/utils.ts

@@ -1,8 +1,11 @@
+import * as t from "io-ts";
 import { Context } from "@azure/functions";
 import { BlobService } from "azure-storage";
 import * as TE from "fp-ts/lib/TaskEither";
 import { CosmosErrors } from "@pagopa/io-functions-commons/dist/src/utils/cosmosdb_model";
 import { pipe } from "fp-ts/lib/function";
+
+import { enumType } from "@pagopa/ts-commons/lib/types";
 import {
   ActivityResultFailure,
   BlobCreationFailure,
@@ -11,6 +14,21 @@ import {
   QueryFailure
 } from "./types";
 
+// Cosmos Errors
+export enum CosmosErrorsTypes {
+  "COSMOS_EMPTY_RESPONSE" = "COSMOS_EMPTY_RESPONSE",
+  "COSMOS_CONFLICT_RESPONSE" = "COSMOS_CONFLICT_RESPONSE",
+  "COSMOS_DECODING_ERROR" = "COSMOS_DECODING_ERROR",
+  "COSMOS_ERROR_RESPONSE" = "COSMOS_ERROR_RESPONSE"
+}
+
+const CosmosErrorsTypesC = t.interface({
+  kind: enumType<CosmosErrorsTypes>(CosmosErrorsTypes, "kind")
+});
+
+export const isCosmosErrors = (error: unknown): error is CosmosErrors =>
+  CosmosErrorsTypesC.is(error);
+
 /**
  * To be used for exhaustive checks
  */

ExtractUserDataActivity/__tests__/handler.test.ts

@@ -120,7 +120,7 @@ const asyncIteratorOf = <T>(items: T[]): AsyncIterator<T[]> => {
       const value = data.shift();
       return {
         done: typeof value === "undefined",
-        value: [value]
+        value: [value!]
       };
     }
   };

ExtractUserDataActivity/handler.ts

@@ -8,9 +8,7 @@ import * as t from "io-ts";
 import { DeferredPromise } from "@pagopa/ts-commons/lib/promises";
 
 import { sequenceS, sequenceT } from "fp-ts/lib/Apply";
-import * as A from "fp-ts/lib/Array";
 import * as ROA from "fp-ts/lib/ReadonlyArray";
-import { flatten, rights } from "fp-ts/lib/Array";
 
 import { Context } from "@azure/functions";
 
@@ -221,8 +219,8 @@ export const getAllMessageContents = (
 > =>
   pipe(
     messages,
-    A.map(_ => _.id),
-    A.map(messageId =>
+    ROA.map(_ => _.id),
+    ROA.map(messageId =>
       pipe(
         messageModel.getContentFromBlob(messageContentBlobService, messageId),
         TE.chainW(
@@ -241,7 +239,7 @@ export const getAllMessageContents = (
         )
       )
     ),
-    A.sequence(TE.ApplicativePar)
+    ROA.sequence(TE.ApplicativePar)
   );
 
 /**
@@ -253,8 +251,8 @@ export const getAllMessagesStatuses = (
 ): TE.TaskEither<ActivityResultQueryFailure, ReadonlyArray<MessageStatus>> =>
   pipe(
     messages,
-    A.map(_ => _.id),
-    A.map(messageId =>
+    ROA.map(_ => _.id),
+    ROA.map(messageId =>
       pipe(
         messageStatusModel.findLastVersionByModelId([messageId]),
         TE.mapLeft(failure =>
@@ -273,7 +271,7 @@ export const getAllMessagesStatuses = (
         )
       )
     ),
-    A.sequence(TE.ApplicativePar)
+    ROA.sequence(TE.ApplicativePar)
   );
 
 /**
@@ -290,8 +288,8 @@ export const findNotificationsForAllMessages = (
 > =>
   pipe(
     messages,
-    A.map(m => notificationModel.findNotificationForMessage(m.id)),
-    A.sequence(TE.ApplicativeSeq),
+    ROA.map(m => notificationModel.findNotificationForMessage(m.id)),
+    ROA.sequence(TE.ApplicativeSeq),
     TE.mapLeft(e =>
       ActivityResultQueryFailure.encode({
         kind: "QUERY_FAILURE",
@@ -304,8 +302,8 @@ export const findNotificationsForAllMessages = (
     // We just filter "none" elements
     TE.map(
       flow(
-        A.filter(O.isSome),
-        A.map(maybeNotification => maybeNotification.value)
+        ROA.filter(O.isSome),
+        ROA.map(maybeNotification => maybeNotification.value)
       )
     )
   );
@@ -321,14 +319,16 @@ export const findAllNotificationStatuses = (
     notifications,
 
     // compose a query for every supported channel type
-    A.reduce([], (queries, { id: notificationId }) => [
-      ...queries,
-      ...Object.values(NotificationChannelEnum).map(channel => [
-        notificationId,
-        channel
-      ])
-    ]),
-    A.map(([notificationId, channel]) =>
+    ROA.reduce(
+      [] as ReadonlyArray<readonly [NonEmptyString, NotificationChannelEnum]>,
+      (queries, { id: notificationId }) => [
+        ...queries,
+        ...Object.values(NotificationChannelEnum).map(
+          channel => [notificationId, channel] as const
+        )
+      ]
+    ),
+    ROA.map(([notificationId, channel]) =>
       pipe(
         notificationStatusModel.findOneNotificationStatusByNotificationChannel(
           notificationId,
@@ -344,13 +344,13 @@ export const findAllNotificationStatuses = (
         )
       )
     ),
-    A.sequence(TE.ApplicativePar),
+    ROA.sequence(TE.ApplicativePar),
 
     // filter empty results (it might not exist a content for a pair notification/channel)
     TE.map(
       flow(
-        A.filter(O.isSome),
-        A.map(someNotificationStatus => someNotificationStatus.value)
+        ROA.filter(O.isSome),
+        ROA.map(someNotificationStatus => someNotificationStatus.value)
       )
     )
   );
@@ -380,18 +380,18 @@ export const queryAllUserData = (
     // step 0: look for the profile
     getProfile(profileModel, fiscalCode),
     // step 1: get messages, which can be queried by only knowing the fiscal code
-    TE.chain(profile =>
+    TE.chainW(profile =>
       sequenceS(TE.ApplicativePar)({
         // queries all messages for the user
         messages: pipe(
           messageModel.findMessages(fiscalCode),
-          TE.chain(iterator =>
+          TE.chainW(iterator =>
             TE.tryCatch(
               () => asyncIteratorToArray(iterator),
               toCosmosErrorResponse
             )
           ),
-          TE.map(flatten),
+          TE.map(ROA.flatten),
           TE.mapLeft(_ =>
             ActivityResultQueryFailure.encode({
               kind: "QUERY_FAILURE",
@@ -408,7 +408,11 @@ export const queryAllUserData = (
                     reason: "Some messages cannot be decoded"
                   })
                 )
-              : TE.of(rights(results))
+              : TE.of(
+                  ROA.rights(results) as ReadonlyArray<
+                    RetrievedMessageWithoutContent
+                  >
+                )
           )
         ),
         messagesView: pipe(
@@ -428,7 +432,7 @@ export const queryAllUserData = (
           TE.chain(iter =>
             TE.tryCatch(() => asyncIteratorToArray(iter), toCosmosErrorResponse)
           ),
-          TE.map(flatten),
+          TE.map(ROA.flatten),
           TE.mapLeft(_ =>
             ActivityResultQueryFailure.encode({
               kind: "QUERY_FAILURE",
@@ -445,7 +449,7 @@ export const queryAllUserData = (
                     reason: "Some messages cannot be decoded"
                   })
                 )
-              : TE.of(rights(results))
+              : TE.of(ROA.rights(results))
           )
         ),
         profile: TE.of(profile),
@@ -469,7 +473,7 @@ export const queryAllUserData = (
       })
     ),
     // step 2: queries notifications and message contents, which need message data to be queried first
-    TE.chain(({ profile, messages, messagesView, servicesPreferences }) =>
+    TE.chainW(({ profile, messages, messagesView, servicesPreferences }) =>
       sequenceS(TE.ApplicativePar)({
         messageContents: getAllMessageContents(
           messageContentBlobService,
@@ -488,7 +492,7 @@ export const queryAllUserData = (
       })
     ),
     // step 3: queries notifications statuses
-    TE.bind("notificationStatuses", ({ notifications }) =>
+    TE.bindW("notificationStatuses", ({ notifications }) =>
       findAllNotificationStatuses(notificationStatusModel, notifications)
     ),
     TE.map(

GetFailedUserDataProcessing/__tests__/handler.test.ts

@@ -13,7 +13,7 @@ const findEntry = (
     PartitionKey: UserDataProcessingChoice;
     RowKey: FiscalCode;
   }>
-) => (choice, fiscalCode) =>
+) => (choice: UserDataProcessingChoice, fiscalCode: FiscalCode) =>
   entries.length > 0
     ? entries
         .filter(e => e.PartitionKey === choice && e.RowKey === fiscalCode)
@@ -56,7 +56,7 @@ const storageTableMock = "FailedUserDataProcessing" as NonEmptyString;
 const fiscalCode1 = "UEEFON48A55Y758X" as FiscalCode;
 const fiscalCode2 = "VEEGON48A55Y758Z" as FiscalCode;
 
-const noFailedRequests = [];
+const noFailedRequests: typeof failedRequests = [];
 
 const failedRequests = [
   {