Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test-only-stacks option to build a subset of stacks #982

Merged

Conversation

pacostas
Copy link
Contributor

Summary

This PR:

  • introduces a new flag/option called --test-only-stacks on the test.sh stacks's script (stacks/scripts/test.sh)
  • Refactors the test.sh script based on the images.json rationale, to reduce duplicate code.
  • Does not change any of the default behavior of the test.sh script as is currently being used from all the stacks.
  • It has been tested against all the jammy-*-stack repos

Use Cases

Due to the stacks that work with the extension, might end up having to support 30 or more stacks (currently is eight), the build process, before running the acceptance tests, might end up being quite long (over an hour). By having conditionally selecting which stacks to build, we enable:

  • Parallelization on the Github workflows and therefore faster builds testing and releases, as we can conditionally specify with the new option/flag, a subset of the stacks to build and test on each github action.
  • Faster local development, as usually the development happens only on one stack e.g. nodejs stack and therefore we can avoid to build/test all the stacks locally by specifying with the --test-only-stacks option the stacks to build.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas
Copy link
Contributor Author

Related PR paketo-community/ubi-base-stack#98

@pacostas pacostas marked this pull request as ready for review September 13, 2024 10:11
@pacostas pacostas requested a review from a team as a code owner September 13, 2024 10:11
@pacostas
Copy link
Contributor Author

@ForestEckhardt Hello!! Could you review this PR when possible?

@ForestEckhardt ForestEckhardt merged commit e987e30 into paketo-buildpacks:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants