Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionaly testing stacks #98

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Aug 16, 2024

Summary

This PR introduces 2 changes:

  1. Refactors the code to test the images that exist on images.json file and not from what is specified on the integration.json file
  2. Adds functionality to test only the images that exist on TEST_ONLY_STACKS env variable, only if TEST_ONLY_STACKS has been set and is not empty, which is being set from the test.sh script (related PR with the implementation PR Allow testing specific stacks #97)

Related issues

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas marked this pull request as ready for review September 12, 2024 13:47
@pacostas pacostas requested a review from a team as a code owner September 12, 2024 13:47
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 82bf0ad into paketo-community:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants