Add support for buildpack API v0.5 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav
force-pushed
the
api/0.5
branch
4 times, most recently
from
a02861d
to
7224939
Compare
ryanmoran
suggested changes
Mar 1, 2021
build.go
Outdated
Comment on lines
258
to
264
| oldAPI := false | ||
| apiV05, _ := semver.NewVersion("0.5") | ||
| if version, err := semver.NewVersion(buildpackInfo.APIVersion); err != nil { | ||
| config.exitHandler.Error(err) | ||
| return | ||
| } else if version.LessThan(apiV05) { | ||
| oldAPI = true | ||
| } |
There was a problem hiding this comment.
Rather than recording this in a variable, oldAPI, that will likely be superseded as soon as a newer API version comes out, can we just record the API version specified in the buildpack and then do the comparisons in the locations that oldAPI appears below? This would be helpful to future developers as they would more easily understand the code in that location.
|
These changes look pretty solid to me! +1 to Ryan's comment above. |
|
Thanks, should be fixed now :) |
ryanmoran
approved these changes
Mar 2, 2021
sophiewigmore
approved these changes
Mar 2, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for BP API v0.5
Fixes #85
Use Cases
Checklist