This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add fixer and new option to commentFormatRule #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
Dec 19, 2017
|
Is there anything that can be done to help you in the review process @ajafff? |
JoshuaKGoldberg
approved these changes
Nov 6, 2018
|
Has this been completed? |
|
I went ahead and fixed up the merge conflicts. Sorry this took so long @smoehrle - the changes look great and I'm excited to get to use them. Thanks so much for sending this PR back in the day! 😊 FYI @MichaelTontchev |
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Jun 15, 2019
I'd mistakenly added it in merging #3583. Whoops.
This was referenced Jun 15, 2019
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[new-rule-option] "allow-trailing-lowercase" option for comment-format
[new-fixer] comment-format