This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 887
[new-rule-option] no-space-keywords for comment-format #4003
Closed
Shinigami92
wants to merge
6
commits into
palantir:master
from
Shinigami92:feature/comment-format-check-space-special-keywords
Closed
[new-rule-option] no-space-keywords for comment-format #4003
Shinigami92
wants to merge
6
commits into
palantir:master
from
Shinigami92:feature/comment-format-check-space-special-keywords
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
changed the title
[WIP] [new-rule-option] no-space-keywords for comment-format
[new-rule-option] no-space-keywords for comment-format
Jul 28, 2018
The formatting in my last push was prettier #4012 |
JoshuaKGoldberg
suggested changes
Nov 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems generally good. Needs documentation on the new option, and I think the hardcoded :
should be removed.
JoshuaKGoldberg
suggested changes
Nov 7, 2018
Will look into the conflict in the next few days |
Hmm, looks like the changes in this PR are actually already resolved by the Please comment here or in #3951 if you think that's a mistake and you'd like this PR to be re-opened! |
I'm with your desicion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
You can add a new object in
comment-format
to add some exceptions for checking special keywords that can ignore the check-space optione.g.:
There is a check that allows an optional colon at the end of the keyword
Is there anything you'd like reviewers to focus on?
in
on line 183CHANGELOG.md entry:
no-space-keywords
incomment-format