-
Notifications
You must be signed in to change notification settings - Fork 887
Upgrade prettier and run over all files #4214
Conversation
Thanks for your interest in palantir/tslint, @aboyton! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
This: * Upgrades Prettier to 1.14 whic adds yml support. * Turns on `trailing commas = all` as that seems to be what most of the code is doing. * Runs prettier over everything This also has the bonus of making future PRs much smaller.
I think its probably a good idea to merge this. @giladgray thoughts? |
@johnwiseheart this is creating a lot of noise for other PRs. I'll go ahead and merge this in. |
I'm very happy to rebase this if that would help. |
@aboyton it's ready to be merged except it fails on Edit: might be this... const t = {
hello: 123,
bye-bye: 45,
// ^ invalid syntax
nested: {
"bird": 2,
~~~~~~ [Unnecessarily quoted property 'bird' found.]
egg: 3,
}
}; |
b4bffe8
to
aecc982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
* Re-ran Prettier on source files again, with some more ignores Continues on #4214 - I either merged incorrectly or missed some file exclusions that were needed. * Fixed up introduced linting errors
#4012 added prettier support but then didn't run it over everything and turned it on for YAML files despite using a version that doesn't support YAML.
This:
trailing commas = all
as that seems to be what most of the code is doing.This also has the bonus of making future PRs much smaller.
PR checklist
Overview of change:
As above, this upgrades Prettier, sets an option and runs it over everything.
Is there anything you'd like reviewers to focus on?
Not much as this is autogenerated but we should check that it hasn't broken anything.
CHANGELOG.md entry:
trailingComma: "all"
and run it over all files.