Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Re-ran Prettier on source files again, with some more ignores #4270

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Re-ran Prettier on source files again, with some more ignores #4270

merged 2 commits into from
Nov 5, 2018

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 5, 2018

PR checklist

Overview of change:

Continues on #4214 - I either merged incorrectly or missed some file exclusions that were needed.

Is there anything you'd like reviewers to focus on?

Two reasons why I'd like to merge this in very quickly:

Of special note is .prettierignore, which has several folders added for data files that shouldn't be formatted.

Josh Goldberg added 2 commits November 5, 2018 17:25
Continues on #4214 - I either merged incorrectly or missed some file exclusions that were needed.
Copy link
Contributor

@johnwiseheart johnwiseheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very difficult to look at all the changes, but the couple that I looked at seem reasonable so LGTM

@JoshuaKGoldberg
Copy link
Contributor Author

Very difficult to look at all the changes

Yeah, sorry about that 🙁. Thanks for the quick review!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 85d87d1 into palantir:master Nov 5, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the more-prettier branch November 5, 2018 23:28
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 6, 2018
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants