Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teardowns in asv benchmarks #17616

Closed
louispotok opened this issue Sep 21, 2017 · 6 comments · Fixed by reef-technologies/pandas#1 or #18388
Closed

Add teardowns in asv benchmarks #17616

louispotok opened this issue Sep 21, 2017 · 6 comments · Fixed by reef-technologies/pandas#1 or #18388
Labels
Clean good first issue Performance Memory or execution speed performance

Comments

@louispotok
Copy link
Contributor

Per @jreback's comment here, we should have teardowns in asv benchmarks, especially in IO benchmarks where we are creating files.

@gfyoung gfyoung added Clean Performance Memory or execution speed performance labels Sep 21, 2017
@jreback jreback added this to the Next Major Release milestone Sep 21, 2017
@jreback
Copy link
Contributor

jreback commented Sep 21, 2017

to be clear, its mainly the io benchmarks or anything that generates an on-disk artifact.

dmanikowski-reef added a commit to reef-technologies/pandas that referenced this issue Oct 16, 2017
Added teardowns for hdfstore, io and packers benchmarks.
brychlicki-reef pushed a commit to reef-technologies/pandas that referenced this issue Oct 19, 2017
Added teardowns for hdfstore, io and packers benchmarks.
brychlicki-reef pushed a commit to reef-technologies/pandas that referenced this issue Oct 19, 2017
Added teardowns for hdfstore, io and packers benchmarks.
@brychlicki-reef
Copy link

brychlicki-reef commented Oct 19, 2017

The comment above references dead link.
So I spent some time familiarizing myself with the original issue and looking for the comment that triggered this issue. Found it, leaving here as back reference so that others don't have go the long way.

A PR for this is on its way from us.

@jreback
Copy link
Contributor

jreback commented Oct 20, 2017

@brychlicki-reef thanks! that would be great

@prudhv16
Copy link

prudhv16 commented Oct 21, 2017

is any one working on it, else could I try this please ?

@brychlicki-reef
Copy link

@prudhv16
Hi, we have the code ready, it just waits for internal code review before sending, so that'd be a waste :), I'd rather you didn't

@prudhv16
Copy link

thank you very much @brychlicki-reef , I will try to find some easy one and try contributing to pandas.

ghost pushed a commit to reef-technologies/pandas that referenced this issue Nov 9, 2017
Added teardowns for hdfstore, io and packers benchmarks.
dmanikowski-reef added a commit to reef-technologies/pandas that referenced this issue Nov 20, 2017
CLN: Added some asv benchmarks teardown functions (pandas-dev#17616)
dmanikowski-reef added a commit to reef-technologies/pandas that referenced this issue Nov 20, 2017
Added teardowns for hdfstore, io and packers benchmarks.
dmanikowski-reef added a commit to reef-technologies/pandas that referenced this issue Nov 20, 2017
Added teardowns for hdfstore, io and packers benchmarks.
dmanikowski-reef added a commit to reef-technologies/pandas that referenced this issue Nov 20, 2017
Added teardowns for hdfstore, io and packers benchmarks.
dmanikowski-reef added a commit to reef-technologies/pandas that referenced this issue Nov 21, 2017
Added teardowns for hdfstore, io and packers benchmarks.
dmanikowski-reef added a commit to reef-technologies/pandas that referenced this issue Nov 21, 2017
Added teardowns for hdfstore, io and packers benchmarks.
jorisvandenbossche pushed a commit that referenced this issue Nov 23, 2017
Added teardowns for hdfstore, io and packers benchmarks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean good first issue Performance Memory or execution speed performance
Projects
None yet
6 participants