-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some asv benchmarks teardown functions (#17616) #1
Conversation
dmanikowski-reef
commented
Oct 16, 2017
•
edited
Loading
edited
- closes Add teardowns in asv benchmarks pandas-dev/pandas#17616
This PR contains 79 commits. Can you please rebase your changes on top of upstream master? |
b18a41c
to
f5b375f
Compare
my mistake, you do have the tag, I misread PR name for commit name, dumb me, sorry |
f5b375f
to
a892fe0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
+ Coverage 91.38% 91.4% +0.02%
=========================================
Files 163 163
Lines 50068 50068
=========================================
+ Hits 45755 45767 +12
+ Misses 4313 4301 -12
Continue to review full report at Codecov.
|
Can anyone take a look at this or give some feedback? Thanks to @brychlicki-reef the number of commits has been fixed :) |
Anyone reviewing, please note pandas-dev#17616 (comment) I cannpt review it for the moment but if no one volunteers in few days, I will try to get back to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Added teardowns for hdfstore, io and packers benchmarks.
@dmanikowski-reef I've made a "recommit" with |