Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some asv benchmarks teardown functions (#17616) #1

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

dmanikowski-reef
Copy link

@dmanikowski-reef dmanikowski-reef commented Oct 16, 2017

@dmanikowski-reef dmanikowski-reef self-assigned this Oct 16, 2017
@dmanikowski-reef dmanikowski-reef requested a review from a team October 16, 2017 21:15
@ppolewicz
Copy link

This PR contains 79 commits. Can you please rebase your changes on top of upstream master?

@brychlicki-reef
Copy link

brychlicki-reef commented Oct 19, 2017

@dmanikowski-reef
First, your commit message should include one of the tags described at https://pandas.pydata.org/pandas-docs/stable/contributing.html#committing-your-code
, without much thinking I'd shoot for PERF: Performance improvement

my mistake, you do have the tag, I misread PR name for commit name, dumb me, sorry

@codecov-io
Copy link

codecov-io commented Oct 19, 2017

Codecov Report

Merging #1 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #1      +/-   ##
=========================================
+ Coverage   91.38%   91.4%   +0.02%     
=========================================
  Files         163     163              
  Lines       50068   50068              
=========================================
+ Hits        45755   45767      +12     
+ Misses       4313    4301      -12
Flag Coverage Δ
#multiple 89.21% <ø> (+0.02%) ⬆️
#single 40.36% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dac633...09fa936. Read the comment docs.

@dmanikowski-reef
Copy link
Author

Can anyone take a look at this or give some feedback? Thanks to @brychlicki-reef the number of commits has been fixed :)

@brychlicki-reef
Copy link

brychlicki-reef commented Oct 25, 2017

Anyone reviewing, please note pandas-dev#17616 (comment)

I cannpt review it for the moment but if no one volunteers in few days, I will try to get back to it

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Added teardowns for hdfstore, io and packers benchmarks.
@ghost ghost force-pushed the asv_teardown branch from a892fe0 to 09fa936 Compare November 9, 2017 01:27
@ghost
Copy link

ghost commented Nov 9, 2017

@dmanikowski-reef I've made a "recommit" with git commit --amend --no-edit && git push --force-with-lease to trigger a new build after hooking up Circle CI and AppVeyor.
Just letting you know not to worry 😉

@dmanikowski-reef dmanikowski-reef merged commit 0e42b1f into master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add teardowns in asv benchmarks
5 participants