Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem Compiling Docs using make.py #20862

Closed
thiviyanT opened this issue Apr 29, 2018 · 4 comments
Closed

Problem Compiling Docs using make.py #20862

thiviyanT opened this issue Apr 29, 2018 · 4 comments
Labels
Build Library building on various platforms Docs good first issue
Milestone

Comments

@thiviyanT
Copy link
Contributor

When there is a space in the name of a parent directory, make.py fails to run.

$ python make.py html

This is the output of the command:

usage: sphinx-build [OPTIONS] SOURCEDIR OUTPUTDIR [FILENAMES...]
sphinx-build: error: cannot find source directory (/Users/usr/Documents/Pandas Sprint/pandas/doc/Sprint/pandas/doc/build/doctrees)

However, when after removing the space from the directory name (i.e. change 'Pandas Sprint' to 'PandasSprint') the python script executed as expected.

Hope this helps.
Thiviyan

@jorisvandenbossche
Copy link
Member

Thanks for the report. I suppose this could be fixed by quoting the paths where we call this in

SOURCE_PATH,

@thiviyanT
Copy link
Contributor Author

Thank you @jorisvandenbossche. I seem to have solved the issue by modifying 3 lines of code. As this will be my first contribution towards the Pandas project I am struggling to write a git commit message that can be readily understood by the community. Would the following message be fine?

DOC: Fix whitespace in pathnames issue by wrapping paths with quotes (#20862)

@jorisvandenbossche
Copy link
Member

@ThiviyanThanapalasingam That sounds good!

@jorisvandenbossche
Copy link
Member

Closed by #20880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Docs good first issue
Projects
None yet
Development

No branches or pull requests

4 participants