DOC: Handle whitespace in pathnames

[thiviyanT]

Fixed make.py - Now should be able to run make.py in paths with whitespaces (#20862)

[codecov]

Codecov Report

Merging #20880 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20880      +/-   ##
==========================================
+ Coverage   92.19%   92.19%   +<.01%     
==========================================
  Files         169      169              
  Lines       50821    50825       +4     
==========================================
+ Hits        46852    46857       +5     
+ Misses       3969     3968       -1

Flag	Coverage Δ
#multiple	90.6% <ø> (ø)	⬆️
#single	42.37% <ø> (-0.01%)	⬇️

Impacted Files	Coverage Δ
pandas/core/window.py	96.4% <0%> (+0.11%)	⬆️
pandas/core/groupby/base.py	91.83% <0%> (+0.72%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a393675...a919eff. Read the comment docs.

[jreback]

@datapythonista @jorisvandenbossche

how does this look?

[datapythonista]

I was taking a look at it yesterday, as I'm not sure in windows the single quotes will handle backslashes well. But unrelated to the ticket I'm getting a segmentation fault when running sphinx-built. Will comment on the ticket with feedback when I manage to test it.

[jorisvandenbossche]

Can't test on Windows at the moment, but for linux this patch works nicely and fixes the problem for me.

[datapythonista]

@ThiviyanThanapalasingam seems like in Windows the paths need to be escaped with double quotes (the backlash is interpreted as an escape character like in \n).

Besides that, I personally find it's not very readable to use backslashes to escape the quotes. Meaning that instead of '\'{}\'' I think it'd be more clear to use "'{}'". Or now that we need to change to double quotes, the opposite: '"{}"'.

Also, I see that there are several paths that are built like source/*.rst (instead of os.path.join('source', '*.rst'). I couldn't try, but I guess sphinx is failing to exclude these files like in unix systems. Do we want to open an issue for making the script work in Windows @jreback?

[datapythonista]

@ThiviyanThanapalasingam do you have time to update the PR based on the feedback I provided?

[thiviyanT]

Yes, I can do that. @datapythonista Have you opened another issue for making the script work in Windows?

[datapythonista]

No, I think it should be just the one you opened.

[jreback]

@datapythonista ?

[datapythonista]

@ThiviyanThanapalasingam can you update the PR based on the previous feedback?

[pep8speaks]

Hello @ThiviyanThanapalasingam! Thanks for updating the PR.

• There are no PEP8 issues in the file doc/make.py !

[datapythonista]

Made the updates to this PR. But seems like there is a new unrelated problem when the path contains whitespaces: #22836

I think that can be addressed in a separate PR. I would merge this on green, but happy to close this and take care of both problems in a new PR.

[jorisvandenbossche]

Let's do that in a separate PR

@ThiviyanThanapalasingam thanks for the original PR!