Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky stata test #25707

Closed
TomAugspurger opened this issue Mar 13, 2019 · 1 comment
Closed

Fix flaky stata test #25707

TomAugspurger opened this issue Mar 13, 2019 · 1 comment
Labels
good first issue IO Stata read_stata, to_stata Unreliable Test Unit tests that occasionally fail
Milestone

Comments

@TomAugspurger
Copy link
Contributor

The test test_write_fspath_all in

def test_write_fspath_all(self, writer_name, writer_kwargs, module):
asserts that two files are byte-for-byte identical. This can fail for files like stata, which encode other information like the current timestamp, in the binary data.

DataFrame.to_stata provides a keyword time_stamp to control whether the timestamp is written in the binary file.

To avoid spurious test failures from writing the first file at timestamp 1, and the second file at timestamp 2, we should pass that keyword through by adding {'time_stamp': False} to the dict in

('to_stata', {}, 'os'),

@jorisvandenbossche
Copy link
Member

Closed by #25714

sighingnow added a commit to sighingnow/pandas that referenced this issue Mar 14, 2019
* master: (22 commits)
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)
  DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728)
  ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720)
  Make Rolling.apply documentation clearer (pandas-dev#25712)
  pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714)
  Json normalize nan support (pandas-dev#25619)
  TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868)
  DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486)
  BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585)
  Fix concat not respecting order of OrderedDict (pandas-dev#25224)
  CLN: remove pandas.core.categorical (pandas-dev#25655)
  TST/CLN: Remove more Panel tests (pandas-dev#25675)
  Pinned pycodestyle (pandas-dev#25701)
  DOC: update date of 0.24.2 release notes (pandas-dev#25699)
  BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644)
  BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592)
  BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602)
  CLN: Remove unused test code (pandas-dev#25670)
  CLN: remove Panel from concat error message (pandas-dev#25676)
  ...

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue IO Stata read_stata, to_stata Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

No branches or pull requests

2 participants