-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: test_yahoo/test_options is failing (return no data) #4028
Comments
still failing sometimes cc @gliptak |
the test_yahoo/test_options is failing sometimes I have seen it fail on Travis and when I run it locally see if u can figure out what it is thanks |
I think @cpcloud's handled the AttributeError and others...are you seeing On Thu, Jun 27, 2013 at 7:56 PM, gliptak notifications@github.com wrote:
|
the option call sometimes returns nothing (not an error just no calls or puts) |
if specifically the options calls failing, I would suspect the parsing of the HTML |
man this is annoying |
i think we should wait for cleanup of data.py...i can finish up this weekend and get to the bottom of this maybe even today |
up 2 you...it seems to work sometimes.... i'll bet that the actual call just returns invalid xml sometimes which really should be treated as an error |
yep, but it's annoying because it's in the method and would be hard to test for the error, because e.g., you could parse in the test and check for the non-null root node, but i bet it willl parse successfully outside the call and then still fail inside |
waiting for data.py cleanup will enable me to only write the error check once since i've consolidated all of the exact copied code in |
ok....I thought you were merging the data cleanup now? |
no i need to do 1 or 2 more things...soon tho |
#3822
test_options
is failingcc @gliptak
The text was updated successfully, but these errors were encountered: