Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: remove test_yahoo options test skipping #4048

Merged
merged 1 commit into from
Jun 26, 2013

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jun 26, 2013

closes #4028

just a reversal of the warnings - seem ok now

@cpcloud
Copy link
Member

cpcloud commented Jun 26, 2013

merge?

jreback added a commit that referenced this pull request Jun 26, 2013
TST: remove test_yahoo options test skipping
@jreback jreback merged commit c9d48b5 into pandas-dev:master Jun 26, 2013
@cpcloud
Copy link
Member

cpcloud commented Jun 26, 2013

2 to go!

@jreback
Copy link
Contributor Author

jreback commented Jun 26, 2013

yerp

@jtratner
Copy link
Contributor

This is still failing for me:

======================================================================
FAIL: test_options (pandas.io.tests.test_yahoo.TestYahoo)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "../pandas/pandas/util/testing.py", line 769, in network_wrapper
    return t(*args, **kwargs)
  File "../pandas/pandas/io/tests/test_yahoo.py", line 120, in test_options
    assert len(calls)==5
AssertionError

@jreback
Copy link
Contributor Author

jreback commented Jun 27, 2013

this works when I run it at the command line.....any reason you can think why this sometimes fails?

@cpcloud
Copy link
Member

cpcloud commented Jun 27, 2013

@jreback pull down my data-reader-test branch. you should be able to repro the failure there if you do git reset --hard HEAD~1 and then run the test suite. it fails because there's a call to dropna without the all argument and the bid and asking price columns are all nans.

@cpcloud
Copy link
Member

cpcloud commented Jun 27, 2013

i've separated all of the tests so that failures are more isolated and we can tell wtf is going on. before that, everything was bundled together in just a few test functions, maybe i'll write something on the wiki about isolating tests as much as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: test_yahoo/test_options is failing (return no data)
3 participants